Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rsc): add modules property to stats.json #1167

Merged
merged 1 commit into from
May 15, 2024
Merged

fix(rsc): add modules property to stats.json #1167

merged 1 commit into from
May 15, 2024

Conversation

sorrycc
Copy link
Member

@sorrycc sorrycc commented May 15, 2024

Close #1110

Summary by CodeRabbit

  • 新功能

    • mako crate的file.rs模块中,为File结构体添加了一个新的公共方法is_css,用于检查文件内容是否为CSS。
    • crates/mako/src/features/rsc.rs文件中,为RscCssModules结构体添加了一个modules: bool字段。
    • examples/rsc/src/a.less文件中,引入了一个CSS规则,将类为.a的元素样式设置为红色。
    • examples/rsc/src/b.module.less文件中,引入了一个CSS规则,将类为.a的元素样式设置为红色。
    • index.tsx文件中,添加了对a.lessb.module.less CSS文件的导入。
  • 文档

    • 更新了index.tsx文件中的导入语句,统一使用单引号替换双引号。

Copy link
Contributor

coderabbitai bot commented May 15, 2024

Walkthrough

整体变更概述:mako crate 的 file.rs 模块新增了用于检查文件内容是否为 CSS 的 is_css 方法;rsc.rs 文件中的 RscCssModules 结构体新增了 modules 字段;index.tsx 文件引入了 a.lessb.module.less 的 CSS 文件。

Changes

文件路径 变更摘要
crates/mako/src/ast/file.rs 新增 File 结构体的 is_css 公共方法
crates/mako/src/features/rsc.rs RscCssModules 结构体中新增 modules 字段
examples/rsc/src/a.less 引入 .a 类的元素样式为红色的 CSS 规则
examples/rsc/src/b.module.less 引入 .a 类的元素样式为红色的 CSS 规则
examples/rsc/src/index.tsx 引入 a.lessb.module.less 的 CSS 文件
packages/create-mako/src/cli.ts 调整了 pathglobSync 的导入顺序
packages/create-mako/templates/react/src/index.tsx 更新了 index.tsx 中的导入语句使用单引号

Poem

兔子编码忙忙碌,CSS 文件添新绿。
导入顺序调整动,代码风格更一致。 🐇📦

Note

Pull Request Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://coderabbit.ai


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sorrycc sorrycc merged commit 076c7e6 into master May 15, 2024
8 checks passed
@delete-merged-branch delete-merged-branch bot deleted the sorrycc-j2c1 branch May 15, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add modules flag for rscCSSModules in stats data
1 participant