Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keep chinese charactors for bundless mode #1160

Merged
merged 1 commit into from
May 14, 2024
Merged

Conversation

sorrycc
Copy link
Member

@sorrycc sorrycc commented May 14, 2024

Summary by CodeRabbit

  • 新功能
    • 在应用中引入了搜索功能。
    • 添加了处理输出模式的逻辑,以处理ASCII字符。
    • 引入了一个新的测试脚本,用于验证特定文件内容中的中文字符。
    • 引入了用于Minifish应用的配置文件,包括入口点、输出设置、模块保留、ASCII处理和自定义注入。
    • app.ts文件中添加了一个输出'中文'的console.log语句。
    • 引入了一个布尔标志isFirstCase,用于控制Mako开发服务器端口的获取逻辑。

Copy link
Contributor

coderabbitai bot commented May 14, 2024

Walkthrough

整体变更概述:更新了 mako crate 中的 comments.rs 文件,移除了来自 mako_core::tracingwarn 导入,并将其局部添加在一个 if 块中。在 js_ast.rs 中的 JsAst 实现中,增加了 OutputMode 枚举的导入,并根据 OutputMode 引入了新的逻辑处理。还引入了新的测试脚本和配置文件,以及一个简单的输出中文字符的文件。

Changes

文件 变更摘要
crates/mako/src/ast/comments.rs 移除了 comments.rs 中来自 mako_core::tracingwarn 导入
crates/mako/src/ast/js_ast.rs 增加了 OutputModejs_ast.rs 中的导入列表;在 JsAst 实现中基于 OutputMode 添加了新逻辑
e2e/fixtures/minifish.ascii/expect.js 引入了一个测试脚本,验证构建结果解析后特定文件内容中是否存在中文字符
e2e/fixtures/minifish.ascii/mako.config.json 引入了配置文件 mako.config.json,为 minifish 应用程序指定了入口点、输出设置、模块保留、ASCII 处理和自定义注入
e2e/fixtures/minifish.ascii/src/app.ts 引入了一个简单的 app.ts 文件,在 minifish.ascii 项目中添加了一个输出 '中文'console.log 语句
scripts/test-hmr.mjs 引入了一个布尔标志 isFirstCase 控制 Mako 开发服务器端口获取的执行;只有在 isFirstCase 为真时才运行端口获取和断言逻辑

Poem

兔子编码忙碌间,代码变更如歌声悠扬。
测试脚本新添入,中文字符闪亮登场。 🐰📜

Note

Pull Request Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://coderabbit.ai


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sorrycc sorrycc merged commit bdfbeee into master May 14, 2024
8 checks passed
@delete-merged-branch delete-merged-branch bot deleted the sorrycc-gr34 branch May 14, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant