Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: watch support watch=parent #1151

Merged
merged 1 commit into from
May 11, 2024
Merged

feat: watch support watch=parent #1151

merged 1 commit into from
May 11, 2024

Conversation

sorrycc
Copy link
Member

@sorrycc sorrycc commented May 11, 2024

Close #1081

Summary by CodeRabbit

  • 重构
    • 优化了src/dev/update.rs中编译器逻辑,使用更简洁的字符串处理方式。

Copy link
Contributor

coderabbitai bot commented May 11, 2024

Walkthrough

整体变更涉及更新了src/dev/update.rs文件中的导出实体声明和逻辑修改。主要改动包括移除了use crate::visitors::virtual_css_modules::is_css_path的引用,以及在impl Compiler块内部逻辑的调整,包括路径处理和CSS路径的处理方式更新。

Changes

文件 变更摘要
crates/mako/src/dev/update.rs 移除了use crate::visitors::virtual_css_modules::is_css_path的引用。修改了impl Compiler块内部逻辑:替换了let with_as_module = format!("{}?asmodule", p_str);let path = path.to_string_lossy().to_string();;替换了`

Poem

代码更新如春风拂面,路径处理有新变化,兔子编程忙碌间,欢歌笑语伴变化。 🐇🌸

Note

Pull Request Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://coderabbit.ai


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sorrycc sorrycc merged commit a2b20f4 into master May 11, 2024
8 checks passed
@delete-merged-branch delete-merged-branch bot deleted the sorrycc-f799 branch May 11, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC:watch 支持触发父节点的变更
1 participant