Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: node polyfill support timers #1142

Merged
merged 1 commit into from
May 9, 2024
Merged

fix: node polyfill support timers #1142

merged 1 commit into from
May 9, 2024

Conversation

sorrycc
Copy link
Member

@sorrycc sorrycc commented May 9, 2024

Close #1138

Summary by CodeRabbit

  • Bug Fixes
    • crates/mako/src/resolve/mod.rs中的do_resolve函数中,优化了错误消息,将日志消息中的"oxc-resolver"替换为"resolver"。
    • e2e/fixtures/node-polyfill/expect.js文件中,添加了pathtimers的polyfill模块。
    • e2e/fixtures/node-polyfill/src/index.tsx中,新增了对timerssetTimeout的导入语句。
    • 更新了package.jsonpackages/mako/package.json中的"node-libs-browser-okam"版本,从"2.2.4"升级到"^2.2.5"

Copy link
Contributor

coderabbitai bot commented May 9, 2024

Walkthrough

这次的变化主要集中在改进错误消息和添加polyfill模块。日志消息中的"oxc-resolver"被替换为"resolver",还有对expect.js文件和index.tsx文件的修改,以及package.json中对版本号的更新。

Changes

文件路径 变更摘要
crates/mako/src/resolve/mod.rs 改进错误消息,替换日志信息中的"oxc-resolver"为"resolver"。
e2e/fixtures/node-polyfill/expect.js 添加pathtimers的polyfill模块。
e2e/fixtures/node-polyfill/src/index.tsx index.tsx中添加了对timerssetTimeout的引入。
package.json "node-libs-browser-okam"的版本从"2.2.4"更新到"^2.2.5"
packages/mako/package.json 更新"node-libs-browser-okam"的版本从"2.2.4""^2.2.5"

Poem

白兔修复bug,
日志消息焕然新。
polyfill添功能,
版本号跃升新。
代码如诗般流畅。

Note

Pull Request Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://coderabbit.ai


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sorrycc sorrycc merged commit b008ac5 into master May 9, 2024
8 checks passed
@delete-merged-branch delete-merged-branch bot deleted the sorrycc-k60b branch May 9, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

node polyfill support timers
1 participant