Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: panic when empty chunk generated #1135

Merged
merged 1 commit into from
May 13, 2024
Merged

Conversation

xusd320
Copy link
Contributor

@xusd320 xusd320 commented May 8, 2024

Close #1130 。在 #899 解决之前,遇到产物为空的 chunk, 先 panic.

Summary by CodeRabbit

  • 新功能

    • js_chunk_file中添加了对空内容的检查,并根据chunk类型发出panic消息。
    • 根据self.stylesheet的存在重新设计了js_chunk_file处理逻辑。
    • 根据use_chunk_parallel调整了入口JS chunk的条件渲染。
  • 导出或公共实体的声明更改

    • mod.rs中的impl<'cp> ChunkPot<'cp>
      • js_chunk_file中添加了对空内容的检查,并根据chunk类型发出panic消息。
      • 根据self.stylesheet的存在重新设计了js_chunk_file处理逻辑。
      • 根据use_chunk_parallel调整了入口JS chunk的条件渲染。

@xusd320 xusd320 requested a review from stormslowly May 8, 2024 10:03
Copy link
Contributor

coderabbitai bot commented May 8, 2024

Walkthrough

整体变更概述:对ChunkPot模块进行了逻辑和控制流方面的重要更改,包括在js_chunk_file中添加了对空内容的检查,并根据self.stylesheet的存在进行了重构处理,以及根据use_chunk_parallel调整了入口JS块的条件渲染。

Changes

文件路径 变更摘要
crates/mako/src/generate/chunk_pot/mod.rs - 添加了对js_chunk_file中空内容的检查,若为空则抛出与块类型相关的信息。
- 根据self.stylesheet的存在,重构了js_chunk_file处理逻辑。
- 根据use_chunk_parallel调整了入口JS块的条件渲染。

Poem

小兔编码忙碌中,逻辑变更点点通。
检查空内容不放过,重构逻辑更精致。
入口JS块条件新,代码如诗韵。

Note

Pull Request Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://coderabbit.ai


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@xusd320 xusd320 requested a review from sorrycc May 8, 2024 10:03
@xusd320 xusd320 requested a review from stormslowly May 11, 2024 08:40
@xusd320 xusd320 merged commit 8a2d889 into master May 13, 2024
8 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/panic-when-chunk-empty branch May 13, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

当产物内容消失时,显式报错
2 participants