Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add global __mako_chunk_load__ #1111

Merged
merged 1 commit into from
May 6, 2024
Merged

feat: add global __mako_chunk_load__ #1111

merged 1 commit into from
May 6, 2024

Conversation

sorrycc
Copy link
Member

@sorrycc sorrycc commented May 6, 2024

Summary by CodeRabbit

  • Bug Fixes

    • 在构建过程中修改了处理临时目录创建和删除逻辑,现在在尝试删除临时目录之前会检查其是否存在。
      • build.js 中,fs.rmdirSync(path.join(root, 'tmp'), { recursive: true }); 被替换为:
        • let tmpDir = path.join(root, 'tmp');
        • if (fs.existsSync(tmpDir)) {
        • fs.rmdirSync(tmpDir, { recursive: true });
      • build.js 中,fs.mkdirSync(path.join(root, 'tmp')); 被替换为:
        • fs.mkdirSync(tmpDir);
  • New Features

    • app_runtime.stpl 文件中添加了一个新的全局变量 __mako_chunk_load__,并赋予其值 requireModule.ensure
      • global.__mako_chunk_load__ = requireModule.ensure 添加在 crates/mako/templates/app_runtime.stpl

@sorrycc sorrycc merged commit 3599eb7 into master May 6, 2024
5 checks passed
Copy link
Contributor

coderabbitai bot commented May 6, 2024

摘要


### 漫游
这次更新涉及到两个主要更改:
1. 在 `app_runtime.stpl` 文件中添加了一个新的全局变量 `__mako_chunk_load__`,赋值为 `requireModule.ensure`。
2. 在 `build.js` 文件中修改了处理构建过程中临时目录创建和删除逻辑,现在会在尝试删除临时目录之前检查其是否存在。

### 更改
| 文件路径                                | 更改摘要                                                                                                                                                                                                                                                                                                                                                                                |
|---------------------------------------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| crates/mako/templates/app_runtime.stpl | 添加了 `global.__mako_chunk_load__ = requireModule.ensure`                                                                                                                                                                                                                                                                                                                            |
| examples/rsc/build.js                 | - 修改了临时目录的处理逻辑,现在会在尝试删除临时目录之前检查其是否存在。<br>- `fs.rmdirSync(path.join(root, 'tmp'), { recursive: true });` →<br>  - `let tmpDir = path.join(root, 'tmp');`<br>  - `if (fs.existsSync(tmpDir)) {`<br>  - `fs.rmdirSync(tmpDir, { recursive: true });`<br>- `fs.mkdirSync(path.join(root, 'tmp'));` →<br>  - `fs.mkdirSync(tmpDir);` |

代码改动如诗般细腻,兔子在键盘上跳跃;
临时目录不再迷惑,新变量在文件中崭露。 🐇✨

Note

Pull Request Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://coderabbit.ai


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@delete-merged-branch delete-merged-branch bot deleted the sorrycc-hxgl branch May 6, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant