Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve px2rem, support selector_black_list and selector_white_list #1043

Merged
merged 11 commits into from
Apr 12, 2024

Conversation

LovePlayCode
Copy link
Contributor

@LovePlayCode LovePlayCode commented Apr 9, 2024

Close #978
Close #920

背景

px2rem 是移动端的一个功能,会基于配置把 px 转成 rem。目前的实现比较简单,需要做一些补充和完善。

#920
#921

Summary by CodeRabbit

  • New Features
    • Enhanced logic for whitelisting and blacklisting properties and selectors in CSS transformation.
    • Improved handling of compound selectors during transformation.
    • Refactored Px2Rem instance creation for simpler initialization.

Copy link
Contributor

coderabbitai bot commented Apr 9, 2024

Walkthrough

The changes in the Mako project streamline the transformation process. css_px2rem.rs now includes enhanced logic for property and selector transformation based on whitelists and blacklists, while config.rs standardizes field names for clarity.

Changes

File Summary
crates/mako/src/visitors/css_px2rem.rs Introduces new imports for regex handling and refines logic for whitelisting and blacklisting properties/selectors. Updates should_transform to consider lists for transformation based on criteria. Adds visit_mut_compound_selector for compound selectors.
crates/mako/src/config.rs Standardizes field names in Px2RemConfig struct: prop_black_list to prop_blacklist, prop_white_list to prop_whitelist, selector_black_list to selector_blacklist, selector_white_list to selector_whitelist.

Poem

A rabbit in the code does play,
Styles transformed in a whimsical way.
Whitelists, blacklists, a dance so neat,
Clarity shines in every feat.
Changes made, a tale complete.

Note

Pull Request Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://coderabbit.ai


Commits Files that changed from the base of the PR and between 1b6d5ae and afb583b.
Files selected for processing (2)
  • crates/mako/src/config.rs (1 hunks)
  • crates/mako/src/visitors/css_px2rem.rs (6 hunks)

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Comment on lines 230 to 231
// TODO: FIXME
// 如果有多个 selector,应该「全满足 whitelist」且「全不满足 blacklist」时才做 transform
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个,参考注释,所以 curr_selector 应该是 curr_selectors。

Comment on lines 43 to 45
// TODO: should have performance issues, need benchmark
let re = Regex::new(pattern).unwrap();
re.is_match(selector)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regex 大量初始化会有性能问题,之前遇到过,在 fn new 里先初始化好,存 struct 里,这里只做匹配就好。

@sorrycc sorrycc changed the title feat: 完成 select_black&select_white feat: improve px2rem, support selector_black_list and selector_white_list Apr 12, 2024
@sorrycc sorrycc merged commit 62b6266 into master Apr 12, 2024
8 checks passed
@delete-merged-branch delete-merged-branch bot deleted the qiannan_rem branch April 12, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

新手任务:完善 px2rem visitor 关于 mako 配置 mako.config.json 的局限性讨论
2 participants