Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(provider): change unresolved indent syntax context to top level after it's been declared #1027

Merged
merged 3 commits into from
Apr 8, 2024

Conversation

stormslowly
Copy link
Member

@stormslowly stormslowly commented Apr 7, 2024

problem

global.x =1;

transformed to

const global = require("global_polyfill")
global.x = 1

after transform global still use the ctxt of unresolved, but actually it should use the ctxt of top level marks.

Summary by CodeRabbit

  • New Features
    • Promoted the emit_js function to be public in the test_helper.rs file.
    • Added a new field top_level_mark to the Provide struct.
    • Added a new struct ToTopLevelVars with associated methods.
    • Implemented ToTopLevelVars for identifier replacements.
    • Updated Provide::new method to accept top_level_mark.
    • Modified visit_mut_module method in Provide for identifier replacement.
    • Added new dependencies and modules.
  • Bug Fixes
    • Updated test functions and transformations.

Copy link
Contributor

coderabbitai bot commented Apr 7, 2024

Walkthrough

The changes encompass enhancing functionality across different files related to transformations and testing. Notable updates include exposing a function, introducing a new parameter, adding structures and methods for identifier handling, and updating dependencies and test cases.

Changes

File Summary
crates/mako/src/test_helper.rs Promoted emit_js function to public for potential external access.
crates/mako/src/transform.rs
crates/mako/src/transformers/transform_provide.rs
- Added top_level_mark parameter to Provide::new
- Introduced top_level_mark field in Provide struct
- Implemented ToTopLevelVars for identifier replacements
- Updated Provide::new and visit_mut_module for context-based replacements
- Updated dependencies, test functions, and transformations.

Poem

Code changes dance,

New paths in a code trance.

Rabbits hop, files align,

Transformations intertwine.

Bugs flee, joy in every line! 🐇✨

Note

Pull Request Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://coderabbit.ai


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@stormslowly
Copy link
Member Author

image

@stormslowly stormslowly changed the title fix(provider): unresolved indent conflict fix(provider): change unresolved indent syntax context to top level after it's been declared Apr 8, 2024
@stormslowly stormslowly merged commit 7f82a65 into master Apr 8, 2024
8 checks passed
@stormslowly stormslowly deleted the fix/unresolved_indent_conflict branch August 9, 2024 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant