Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade twitter social config to x #2113

Merged
merged 9 commits into from
Jul 29, 2024

Conversation

kiner-tang
Copy link
Contributor

🤔 这个变动的性质是?/ What is the nature of this change?

  • 新特性提交 / New feature
  • bug 修复 / Fix bug
  • 样式优化 / Style optimization
  • 代码风格优化 / Code style optimization
  • 性能优化 / Performance optimization
  • 构建优化 / Build optimization
  • 网站、文档、Demo 改进 / Website, documentation, demo improvements
  • 重构代码或样式 / Refactor code or style
  • 测试相关 / Test related
  • 其他 / Other

🔗 相关 Issue / Related Issue

💡 需求背景和解决方案 / Background or solution

📝 更新日志 / Changelog

Language Changelog
🇺🇸 English update Twitter icon to X
🇨🇳 Chinese 将 Twitter 的 icon 换成 X

Copy link

vercel bot commented May 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dumi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 1:50am

PeachScript
PeachScript previously approved these changes May 12, 2024
@kiner-tang
Copy link
Contributor Author

image
image
我在想这个 title 要不要也改成 X,还是说继续保持用 Twitter

@PeachScript
Copy link
Member

我在想这个 title 要不要也改成 X,还是说继续保持用 Twitter

可以改了,配置项得加个 x,原有的 twitter 配置项依旧生效

@kiner-tang kiner-tang changed the title feat: update twitter icon to X feat: support twitter new icon X May 13, 2024
@kiner-tang
Copy link
Contributor Author

我在想这个 title 要不要也改成 X,还是说继续保持用 Twitter

可以改了,配置项得加个 x,原有的 twitter 配置项依旧生效

done

docs/theme/default.md Outdated Show resolved Hide resolved
@PeachScript
Copy link
Member

原有的 twitter 配置项依旧生效

@kiner-tang 我表述的有歧义,原有的 twitter 配置项也用新的 X 文本和图标,只是一个向前兼容的配置 👀

@kiner-tang
Copy link
Contributor Author

原有的 twitter 配置项依旧生效

@kiner-tang 我表述的有歧义,原有的 twitter 配置项也用新的 X 文本和图标,只是一个向前兼容的配置 👀

意思是无论用户配置的是 twitter 还是 x 我们都展示 x 的图标和文案吗

@PeachScript
Copy link
Member

意思是无论用户配置的是 twitter 还是 x 我们都展示 x 的图标和文案吗

是的,因为 twitter 就是 X,没必要再留着旧图标

@PeachScript PeachScript self-requested a review May 30, 2024 07:30
@PeachScript PeachScript dismissed their stale review June 11, 2024 09:35

Twitter also use the new icon

@kiner-tang
Copy link
Contributor Author

意思是无论用户配置的是 twitter 还是 x 我们都展示 x 的图标和文案吗

是的,因为 twitter 就是 X,没必要再留着旧图标

done

docs/theme/default.md Outdated Show resolved Hide resolved
@PeachScript PeachScript changed the title feat: support twitter new icon X feat: upgrade twitter social config to x Jul 29, 2024
@PeachScript PeachScript merged commit 3d9067b into umijs:master Jul 29, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants