-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add cosmwasm to umeed #809
Conversation
Codecov Report
@@ Coverage Diff @@
## main #809 +/- ##
==========================================
- Coverage 51.20% 45.05% -6.16%
==========================================
Files 67 74 +7
Lines 6659 7657 +998
==========================================
+ Hits 3410 3450 +40
- Misses 3009 3965 +956
- Partials 240 242 +2
|
Due to this issue |
I will try to run some contracts cw-plus to test this integration |
Talking with @brandoncomer, we probably are going to use the wasmd as permissioned as Osmosis did After testing around some contracts lime cw20-basic I will change to be permissioned |
deploy a new cw20 Where artifacts/cw20_base.wasm was generated cw-plus repo
|
I was writing a script to test cw20 but got stuck running
|
Note that for use as collateral, the oracle module (or mock oracle during testing) must have prices for both the borrowed and assets. |
This error was because we have our own function to verify address and it had check for size of 20, and the cosmwasm contract addr was 32 bytes |
@RafilxTenfen can we close this? afaik cosmwasm won't be ready to integrate until 0.47 |
We can discuss that, one way to integrate (and still keep as a draft, but updated) would be to use one branch with 0.46 CosmWasm/wasmd#938 |
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@gsk967 Probably you are doing this in a new branch, take a look at I think we could close this PR but not delete the branch until the new umeed + cosmwasm works with https://github.com/umee-network/umee-cosmwasm |
Description
closes: #802
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change