Add nav2_dwb_controller package #10
Conversation
| @@ -0,0 +1,7 @@ | |||
| dwb_msgs | |||
There was a problem hiding this comment.
Why do we need this file? Maybe we can put it all together in minimal_repos.txt??
There was a problem hiding this comment.
Merging into feat/update_humble sounds good!
Regarding the file, that was my first intention the problem is that this file is used in two commands:
Here in the rosdep install:
apt-get update && rosdep install -q -y \
--from-paths $(awk '$0="src/navigation2/"$0' ./minimal_repos.txt) \
--ignore-src \
&& rm -rf /var/lib/apt/lists/*
And in the colcon build:
--symlink-install \
--mixin \
$OVERLAY_MIXINS \
--packages-select $(cat ./nav2_pkgs.txt) $(cat ./minimal_repos.txt) \
The problem is that in the first command it looks for packages at path : src/navigation2 while these packages are located in src/navigation2/nav2_dwb_controller which makes this command to fail. And if you add the entire path in the minimal_repos.txt then it fails the colcon build because it expects only the name of the package so dwb_core for example and not the entire path. I solved this issue by adding all these pkgs in a second file, but if you have a better alternative I am open to discuss it.
There was a problem hiding this comment.
The branch for humble is the feat/humble_main no? Because I cannot find feat/update_humble
There was a problem hiding this comment.
Yes sorry, I meant feat/humble_main
I understand now the issue with the files. Lets leave it like this and if we think of a cleaner solution we can still do it in the PR of Humble. Thanks for the clarification Bianca!
Basic Info
Description of contribution in a few bullet points
Add nav2_dwb_controller and its dependencies to umd nav2.
This package is needed to substitute the controller plugin PositionController used for Copters to a suitable controller plugin for AMRs. In this case, the dwb controller.
Description of documentation updates required from your changes
Future work that may be required in bullet points