LIBAVALON-106. Set default thumbnail for videos #82
+39
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifed MasteFile generation to replace the "thumbnail" image derived from the video file, with a stock default thumbnail image. This prevents a multitude of videos with black/empty thumbnail images from being displayed on the "Browse" page, and provides a visual indication to curators that a thumbnail needs to be chosen. Added a "set_default_thumbnail" method the "MasterFile" class, and modified the MasterFileBuilder (called when a item is added manually) and the "Avalon::Batch::Entry" class (called when an item is added via a batch process) to call the method. https://issues.umd.edu/browse/LIBAVALON-106
MasterFile for videos should now use the "video_icon.png" by default for the thumbnail, so updated the relevant tests to reflect this change. Modified the FactoryBot MasterFile factory to run the "set_default_thumbnail" method with creating a MasterFile with a thumbnail. https://issues.umd.edu/browse/LIBAVALON-106
dsteelma-umd
force-pushed
the
avalon-develop
branch
2 times, most recently
from
29470fd to
7d73d9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This pull request needs to be demonstrated/approved by stakeholders before being merged.
Modified MasteFile generation to replace the "thumbnail" image derived
from the video file, with a stock default thumbnail image.
This prevents a multitude of videos with black/empty thumbnail images
from being displayed on the "Browse" page, and provides a visual
indication to curators that a thumbnail needs to be chosen.
Added a "set_default_thumbnail" method the "MasterFile" class, and
modified the MasterFileBuilder (called when a item is added manually)
and the "Avalon::Batch::Entry" class (called when an item is added
via a batch process) to call the method.
Updated rspec tests to reflect changes.
https://issues.umd.edu/browse/LIBAVALON-106