Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy htsget-http-lambda. #81

Merged
merged 24 commits into from
May 20, 2022
Merged

Deploy htsget-http-lambda. #81

merged 24 commits into from
May 20, 2022

Conversation

mmalenic
Copy link
Member

The following pull request adds an example of deploying htsget-http-lambda using aws-cdk. The cdk stack is deployed as a RustFunction using rust.aws-cdk-lambda - which uses cargo-lambda for compiling - and is integrated with aws api gateway.

Changes:

  • aws-cdk stack for deploying htsget-http-lambda.
  • Various bug-fixes within htsget-rs to ensure proper behaviour.
  • Some added server tests, and a set of integration tests for htsget-http-lambda, using example events in data/events.

mmalenic added 24 commits May 5, 2022 10:52
@mmalenic
Init files from s3-rust-noodles-bam.
21ed425
@mmalenic
Change files to target htsget-http-lambda.
7c21ef3
@mmalenic
Add tracing to htsget-http-lambda
3fa1c57
@mmalenic
Lambda works locally using cargo lambda.
1e9a8ea
@mmalenic
Remove unused imports.
fa34ccd
@mmalenic
Simplify info messages.
f1df832
@mmalenic
Change incorrect logic for key and cert file config.
019c67a
@mmalenic
Correct QueryMap error in tests.
9cc7485
@mmalenic
Cdk synth succeeds.
6803444
@mmalenic
Add tags, name and description to stack.
005e662
@mmalenic
Apply tags within stack.
27721c7
@mmalenic
Add tracing to search and core crates.
70cedc3
@mmalenic
Add tracing to http-actix.
c9a937d
@mmalenic
Move config tracing to config crate.
542f233
@mmalenic
Add debug log level, add more descriptive errors.
e35504b
@mmalenic
Check retrieval type in storage.
651cd3d
@mmalenic
Cleanup and warnings.
71a4163
@mmalenic
Fix incorrectly set bucket.
68bac55
@mmalenic
Allow matching endpoints to be more lenient towards apigw stages.
b130f55
@mmalenic
Get path using http-lambda, and remove unwraps and expects.
1d253e2
@mmalenic
Update deploy files.
7fc683c
@mmalenic
Add cargo-lambda integration tests, remove content type restriction, …
66c94a1 
…allow null body for post requests.
@mmalenic
Add another post test, more informative errors for invalid content-ty…
03d1511 
…pe, update readme.
@mmalenic
Add tests to actix-web.
a6e0233
brainstorm
brainstorm approved these changes May 20, 2022
View reviewed changes
Copy link
Member

@brainstorm brainstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing, so glad to see this finally getting merged, I'm glad that the s3-rust-noodles-bam PoC facilitated this :D

Nitpick: I'm a bit unsure of tracing:debug! being the most appropriate logging construct, but we can refine that later...

Can you refer the cargo-lambda issue we discussed over slack (single shot & retry features for CI) in this PR as a comment? I'd like to keep track of that one.

@brainstorm brainstorm merged commit ca65961 into main May 20, 2022
@mmalenic
Copy link
Member Author

cargo-lambda/cargo-lambda#153

@brainstorm brainstorm deleted the real_integration_tests branch May 27, 2022 00:44
@github-actions github-actions bot mentioned this pull request May 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brainstorm brainstorm brainstorm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmalenic @brainstorm