Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable choosing between storage types. #80

Merged
merged 12 commits into from
May 4, 2022
Merged

Enable choosing between storage types. #80

merged 12 commits into from
May 4, 2022

Conversation

mmalenic
Copy link
Member

@mmalenic mmalenic commented May 4, 2022

This PR enables choosing between using LocalStorage and AwsS3Storage. It also refactors a bit of code in the some of the crates.

Changes:

  • Add StorageType config option which allows choosing between LocalStorage and AwsS3Storage.
  • Refactor some config options.
  • Update usage text.
  • Add a few tests for the config options.

Further improvements may involve adding the ability to setup multiple resolvers, that map to arbitrary storage types. For example, an id starting with "aws-{id}" could map to an AwsS3Storage, whereas an id starting with "local-{id}" could map to LocalStorage.

Copy link
Member

@brainstorm brainstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the failing tests, thanks for this @mmalenic! ;P

Now we can finally change between storage backends along with the massive config refactor, awesome. Let's tackle lambdas and API Gateways next, shall we? :)

@mmalenic mmalenic merged commit 76376bd into main May 4, 2022
@brainstorm brainstorm deleted the enable_config branch May 27, 2022 00:49
@github-actions github-actions bot mentioned this pull request May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants