Described option for using underscores in product keys when configuring product licenses with environment variables. #6747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng product licenses with environment variables.
sofietoft
reviewed
Dec 16, 2024
| @@ -67,6 +67,14 @@ Once you have received your license code it needs to be installed on your site. | |||
| } | |||
| ``` | |||
|
|
|||
| {% hint style="info" %} | |||
| If using environment variables rather than a JSON file for configuration you may run into issues with the periods used in the product key. If so, an underscore can be used instead: | |||
There was a problem hiding this comment.
Could this, an potentially the rest, be stripped down to this? Or is it lacking too much detail? 🤔
Suggested change
| If using environment variables rather than a JSON file for configuration you may run into issues with the periods used in the product key. If so, an underscore can be used instead: | |
| Use an underscore in the product name, to avoid issues when using environment variables. |
There was a problem hiding this comment.
It would be OK, but the detail is kind of useful too for background, and also as we've documented above using the ".".
There was a problem hiding this comment.
Yeah, I see 🤔
How about:
"When using environment variables you might run into issues when using a period in the product name. Use an underscore in the product name instead, to avoid issues."
There was a problem hiding this comment.
Sounds fine, do you want me to make that update or will you do so?
There was a problem hiding this comment.
I can update the notes 💪
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Described option for using underscores in product keys when configuring product licenses with environment variables.
Type of suggestion
Product & version (if relevant)
Commerce, UI Builder, Engage and Deploy (on-premise)
Deadline (if relevant)
Any time.