Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change code example from Implements to Extends #6690

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

warrenbuckley
Copy link
Contributor

@warrenbuckley warrenbuckley commented Nov 21, 2024

Description

What did you add/update/change?

A code sample for the UFM component example, using implements means I needed to do more than what I needed to do.
Looked at the source code of the existing UFM-Components and they use the extends approach instead so we only need to implement the render method

Type of suggestion

  • Typo/grammar fix
  • Updated outdated content
  • New content
  • Updates related to a new version
  • Other

Product & version (if relevant)

Deadline (if relevant)

When should the content be published?

@sofietoft
Copy link
Contributor

Thanks @warrenbuckley !
This makes a lot of sense 💪

Let's get it merged!

@sofietoft sofietoft merged commit 3f5da27 into umbraco:main Nov 21, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants