Fixes Issue 4391 #4403
Merged
Fixes Issue 4391 #4403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonat123
reviewed
Sep 26, 2022
|
@eshanrnh Looks good to me :) Only thing is i remember @sofietoft and i talked about the article not being up to the standard of articles that we wanted in our docs, however i can see that changes has been made to it so i guess it has been reworked and is okay now? If that is the case maybe we should also link it somewhere so people can actually find it :) |
|
Hey @jonat123 Yup, the article has been reworked and I've added a link from the Custom Routing article so it's easier to find. |
jonat123
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4391