Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Default Workspace Kind + Collection Workspace View Kind #2309

Merged
merged 37 commits into from
Sep 26, 2024

Conversation

madsrasmussen
Copy link
Contributor

@madsrasmussen madsrasmussen commented Sep 17, 2024

Description

We have a lot of workspaces across the Backoffice that need to show a collection. This PR introduces new kinds to remove the need for custom elements in these cases. These are the workspaces updated as part of this PR:

  • Member Root
  • Member Group Root
  • User Root
  • User Group Root
  • Webhook Root
  • Language Root
  • Extension Insights Root
  • Relations Root

All of the above workspaces are now set up by manifests only.

New Kinds

Default Workspace
The kind renders a workspace editor with workspace views, workspace actions, entity actions, etc. This is the basic setup to get started with a workspace. For more advanced workspaces the 'routable' kind is still available.

type: 'workspace',
kind: 'default'

Collection Workspace View
The kind renders a collection element inside a workspace view based on the collectionAlias set in the manifest

type: 'workspaceView',
kind: 'collection'

Content Collection Workspace View
The kind renders a collection based on a data type configuration.

type: 'workspaceView',
kind: 'contentCollection'

Caution

Breaking changes

Prefixing collections used as part of content
The collection kind already existed in the system but the logic depended on a data type. The kind has been updated to contentCollection. The new collection-kind only requires a collectionAlias to work.

Current kind: collection -> contentCollection.

Rename of UmbCollectionWorkspaceContext -> UmbContentCollectionWorkspaceContext. Import is moved from @umbraco-cms/backoffice/workspace to @umbraco-cms/backoffice/content

Rename of UMB_COLLECTION_WORKSPACE_CONTEXT -> UMB_CONTENT_COLLECTION_WORKSPACE_CONTEXT. Import moved from @umbraco-cms/backoffice/workspace to @umbraco-cms/backoffice/content

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

@iOvergaard iOvergaard deleted the branch main September 18, 2024 09:11
@iOvergaard iOvergaard closed this Sep 18, 2024
@iOvergaard iOvergaard reopened this Sep 18, 2024
@iOvergaard iOvergaard changed the base branch from v15/dev to main September 18, 2024 09:12
@madsrasmussen madsrasmussen marked this pull request as ready for review September 18, 2024 13:06
@nielslyngsoe nielslyngsoe merged commit e6a5750 into main Sep 26, 2024
8 checks passed
@nielslyngsoe nielslyngsoe deleted the v15/feature/collection-kind-workspace-view branch September 26, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants