-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Default Workspace Kind + Collection Workspace View Kind #2309
Merged
nielslyngsoe
merged 37 commits into
main
from
v15/feature/collection-kind-workspace-view
Sep 26, 2024
Merged
Feature: Default Workspace Kind + Collection Workspace View Kind #2309
nielslyngsoe
merged 37 commits into
main
from
v15/feature/collection-kind-workspace-view
Sep 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 717054c.
…eature/collection-kind-workspace-view
nielslyngsoe
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have a lot of workspaces across the Backoffice that need to show a collection. This PR introduces new
kinds
to remove the need for custom elements in these cases. These are the workspaces updated as part of this PR:All of the above workspaces are now set up by manifests only.
New Kinds
Default Workspace
The kind renders a workspace editor with workspace views, workspace actions, entity actions, etc. This is the basic setup to get started with a workspace. For more advanced workspaces the 'routable' kind is still available.
Collection Workspace View
The kind renders a collection element inside a workspace view based on the collectionAlias set in the manifest
Content Collection Workspace View
The kind renders a collection based on a data type configuration.
Caution
Breaking changes
Prefixing collections used as part of content
The
collection
kind already existed in the system but the logic depended on a data type. The kind has been updated tocontentCollection
. The newcollection
-kind only requires acollectionAlias
to work.Current kind:
collection
->contentCollection
.Rename of
UmbCollectionWorkspaceContext
->UmbContentCollectionWorkspaceContext
. Import is moved from@umbraco-cms/backoffice/workspace
to@umbraco-cms/backoffice/content
Rename of
UMB_COLLECTION_WORKSPACE_CONTEXT
->UMB_CONTENT_COLLECTION_WORKSPACE_CONTEXT
. Import moved from@umbraco-cms/backoffice/workspace
to@umbraco-cms/backoffice/content
Types of changes