Skip to content

Commit

Permalink
Merge pull request #2332 from umbraco/v15/fix/embedded-media-package
Browse files Browse the repository at this point in the history
Feature: Embedded media package
  • Loading branch information
madsrasmussen authored Sep 24, 2024
2 parents dda914f + e744fc6 commit 3ce4c5f
Show file tree
Hide file tree
Showing 25 changed files with 63 additions and 34 deletions.
5 changes: 5 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
"./context-api": "./dist-cms/libs/context-api/index.js",
"./controller-api": "./dist-cms/libs/controller-api/index.js",
"./element-api": "./dist-cms/libs/element-api/index.js",
"./embedded-media": "./dist-cms/packages/embedded-media/index.js",
"./extension-api": "./dist-cms/libs/extension-api/index.js",
"./formatting-api": "./dist-cms/libs/formatting-api/index.js",
"./localization-api": "./dist-cms/libs/localization-api/index.js",
Expand Down
1 change: 1 addition & 0 deletions src/apps/backoffice/backoffice.element.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ const CORE_PACKAGES = [
import('../../packages/data-type/umbraco-package.js'),
import('../../packages/dictionary/umbraco-package.js'),
import('../../packages/documents/umbraco-package.js'),
import('../../packages/embedded-media/umbraco-package.js'),
import('../../packages/extension-insights/umbraco-package.js'),
import('../../packages/health-check/umbraco-package.js'),
import('../../packages/help/umbraco-package.js'),
Expand Down
13 changes: 0 additions & 13 deletions src/packages/core/modal/common/embedded-media/manifests.ts

This file was deleted.

This file was deleted.

1 change: 0 additions & 1 deletion src/packages/core/modal/common/index.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
export * from './embedded-media/index.js';
export * from './confirm/index.js';
export * from './item-picker/index.js';
11 changes: 1 addition & 10 deletions src/packages/core/modal/common/manifests.ts
Original file line number Diff line number Diff line change
@@ -1,13 +1,4 @@
import { manifests as confirmManifests } from './confirm/manifests.js';
import { manifests as itemPickerManifests } from './item-picker/manifests.js';

export const manifests: Array<UmbExtensionManifest> = [
{
type: 'modal',
alias: 'Umb.Modal.EmbeddedMedia',
name: 'Embedded Media Modal',
element: () => import('./embedded-media/embedded-media-modal.element.js'),
},
...confirmManifests,
...itemPickerManifests,
];
export const manifests: Array<UmbExtensionManifest> = [...confirmManifests, ...itemPickerManifests];
1 change: 0 additions & 1 deletion src/packages/core/modal/token/index.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
export * from './change-password-modal.token.js';
export * from './embedded-media-modal.token.js';
export * from './modal-token.js';
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
export * from './modal/index.js';
export * from './repository/index.js';
4 changes: 4 additions & 0 deletions src/packages/embedded-media/manifests.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
import { manifests as modalManifests } from './modal/manifests.js';
import { manifests as repositoryManifests } from './repository/manifests.js';

export const manifests: Array<UmbExtensionManifest> = [...modalManifests, ...repositoryManifests];
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { UmbOEmbedRepository } from './repository/oembed.repository.js';
import { UmbOEmbedRepository } from '../repository/oembed.repository.js';
import type { UmbEmbeddedMediaModalData, UmbEmbeddedMediaModalValue } from './embedded-media-modal.token.js';
import { css, html, unsafeHTML, when, customElement, state } from '@umbraco-cms/backoffice/external/lit';
import { UmbTextStyles } from '@umbraco-cms/backoffice/style';
import type { UmbEmbeddedMediaModalData, UmbEmbeddedMediaModalValue } from '@umbraco-cms/backoffice/modal';
import { UmbModalBaseElement } from '@umbraco-cms/backoffice/modal';
import type { UUIButtonState, UUIInputEvent } from '@umbraco-cms/backoffice/external/uui';

Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import '../../../components/body-layout/body-layout.element.js';
import './embedded-media-modal.element.js';

import type { UmbEmbeddedMediaModalData } from './embedded-media-modal.token.js';
import type { Meta } from '@storybook/web-components';
import { html } from '@umbraco-cms/backoffice/external/lit';
import type { UmbEmbeddedMediaModalData } from '@umbraco-cms/backoffice/modal';

export default {
title: 'API/Modals/Layouts/Embedded Media',
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { UmbModalToken } from './modal-token.js';
import { UmbModalToken } from '@umbraco-cms/backoffice/modal';

export interface UmbEmbeddedMediaModalData extends Partial<UmbEmbeddedMediaDimensionsModel> {
url?: string;
Expand Down
1 change: 1 addition & 0 deletions src/packages/embedded-media/modal/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export * from './embedded-media-modal.token.js';
8 changes: 8 additions & 0 deletions src/packages/embedded-media/modal/manifests.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
export const manifests: Array<UmbExtensionManifest> = [
{
type: 'modal',
alias: 'Umb.Modal.EmbeddedMedia',
name: 'Embedded Media Modal',
element: () => import('./embedded-media-modal.element.js'),
},
];
8 changes: 8 additions & 0 deletions src/packages/embedded-media/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"name": "@umbraco-backoffice/embedded-media",
"private": true,
"type": "module",
"scripts": {
"build": "vite build"
}
}
1 change: 1 addition & 0 deletions src/packages/embedded-media/repository/constants.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export const UMB_OEMBED_REPOSITORY_ALIAS = 'Umb.Repository.OEmbed';
2 changes: 2 additions & 0 deletions src/packages/embedded-media/repository/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
export * from './oembed.repository.js';
export * from './constants.js';
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
export const UMB_OEMBED_REPOSITORY_ALIAS = 'Umb.Repository.OEmbed';
import { UMB_OEMBED_REPOSITORY_ALIAS } from './constants.js';

export const manifests: Array<UmbExtensionManifest> = [
{
Expand Down
9 changes: 9 additions & 0 deletions src/packages/embedded-media/umbraco-package.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
export const name = 'Umbraco.Core.EmbeddedMedia';
export const extensions = [
{
name: 'Embedded Media Bundle',
alias: 'Umb.Bundle.EmbeddedMedia',
type: 'bundle',
js: () => import('./manifests.js'),
},
];
12 changes: 12 additions & 0 deletions src/packages/embedded-media/vite.config.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import { defineConfig } from 'vite';
import { rmSync } from 'fs';
import { getDefaultConfig } from '../../vite-config-base';

const dist = '../../../dist-cms/packages/embedded-media';

// delete the unbundled dist folder
rmSync(dist, { recursive: true, force: true });

export default defineConfig({
...getDefaultConfig({ dist }),
});
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import { type TinyMcePluginArguments, UmbTinyMcePluginBase } from '../components/input-tiny-mce/tiny-mce-plugin.js';
import { UmbLocalizationController } from '@umbraco-cms/backoffice/localization-api';
import type { UmbEmbeddedMediaModalData, UmbEmbeddedMediaModalValue } from '@umbraco-cms/backoffice/modal';
import { UMB_EMBEDDED_MEDIA_MODAL, UMB_MODAL_MANAGER_CONTEXT } from '@umbraco-cms/backoffice/modal';
import type { UmbEmbeddedMediaModalData, UmbEmbeddedMediaModalValue } from '@umbraco-cms/backoffice/embedded-media';
import { UMB_MODAL_MANAGER_CONTEXT } from '@umbraco-cms/backoffice/modal';
import { UMB_EMBEDDED_MEDIA_MODAL } from '@umbraco-cms/backoffice/embedded-media';

export default class UmbTinyMceEmbeddedMediaPlugin extends UmbTinyMcePluginBase {
constructor(args: TinyMcePluginArguments) {
Expand Down
1 change: 1 addition & 0 deletions tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ DON'T EDIT THIS FILE DIRECTLY. It is generated by /devops/tsconfig/index.js
"@umbraco-cms/backoffice/context-api": ["./src/libs/context-api/index.ts"],
"@umbraco-cms/backoffice/controller-api": ["./src/libs/controller-api/index.ts"],
"@umbraco-cms/backoffice/element-api": ["./src/libs/element-api/index.ts"],
"@umbraco-cms/backoffice/embedded-media": ["./src/packages/embedded-media/index.ts"],
"@umbraco-cms/backoffice/extension-api": ["./src/libs/extension-api/index.ts"],
"@umbraco-cms/backoffice/formatting-api": ["./src/libs/formatting-api/index.ts"],
"@umbraco-cms/backoffice/localization-api": ["./src/libs/localization-api/index.ts"],
Expand Down

0 comments on commit 3ce4c5f

Please sign in to comment.