Refactor and clean up grid previews #9410
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
After merging #9242, I had a closer look at the grid preview, which lead to a closer look at the grid property editor, which lead to a chunk of refactoring and cleanup, which lead to this PR.
umb-grid-preview--
namespaceTo test, verify the UI works correctly and is consistent across the different views (grid editor, prevalues, row and layout overlays), can add/remove columns in a layout/row, can delete rows/columns, etc - all existing behaviours should continue to work fine, these changes are UI only.
Prevalues / datatype config
Before:
After:
Layout config overlay
Before:
After:
Row config overlay
Before:
After: