Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V8: Allow localization of the backoffice using parent cultures to the editor culture #6090

Merged

Conversation

kjac
Copy link
Contributor

@kjac kjac commented Aug 10, 2019

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes #5959

Description

This is a new take on the issue outlined in #4519. The PR reverts the changes from #4519 and handles dictionary based localization via region-less languages in a different way.

Setup for testing this PR

First and foremost make sure you have created both a region specific and a region-less language - e.g. add "da" if you still have the default "en-US":

image

Create a doctype that localizes both its name and a property label via the dictionary (using the "#" notation):

image

Add two dictionary entries, one for the name of the doctype and one for the name property label:

image

image

Testing this PR

Set your user language to match the region-less language you created above - e.g. use "da-DK" as your user language if you created "da".

Verify that the localization works by testing the following:

  1. The doctype name in create dialog:
    image

  2. The property label in the doctype editor:
    image

  3. The doctype name in the "Info" section:
    image

Now change your user language to match the region specific language you created above and redo the verification of localization for this language.

@nul800sebastiaan nul800sebastiaan merged commit 4055385 into umbraco:v8/dev Aug 13, 2019
@nul800sebastiaan
Copy link
Member

I checked all the usages of this now a couple of times and this is a much better fix in the first place. Good find of that other method, it seems to be exactly made for this and we don't have to break the other one either (or at least.. it's being "unbroken" now!).

Thanks very much! 👍

nul800sebastiaan pushed a commit that referenced this pull request Aug 13, 2019
@kjac kjac deleted the v8-fix-localization-parent-cultures branch August 13, 2019 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LocalizationService.GetLanguageByIsoCode my return language different to the one requested
3 participants