-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clipboard feature: clipboard property value cloner #17824
Merged
madsrasmussen
merged 17 commits into
v15/feature/clipboard
from
v15/feature/clipboard-property-value-transformer
Dec 19, 2024
Merged
clipboard feature: clipboard property value cloner #17824
madsrasmussen
merged 17 commits into
v15/feature/clipboard
from
v15/feature/clipboard-property-value-transformer
Dec 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rty-value-transformer
nielslyngsoe
changed the title
feature: clipboard property value cloner
clipboard feature: clipboard property value cloner
Dec 16, 2024
…rty-value-transformer
…rty-value-transformer
madsrasmussen
approved these changes
Dec 19, 2024
…rty-value-transformer # Conflicts: # src/Umbraco.Web.UI.Client/src/packages/block/block-list/manifests.ts
madsrasmussen
deleted the
v15/feature/clipboard-property-value-transformer
branch
December 19, 2024 11:32
nielslyngsoe
added a commit
that referenced
this pull request
Jan 16, 2025
* wip clipboard context + tests * clean up property action module + register copy action * split manifests * add clipboard module * import type * export type * mark all methods async * scaffold copy + paste property actions * scaffold workspace, collection, repo + data sources * remove references to language * register detail manifests * call repo when creating * load clipboard collection data * remove debugger * register clipboard item picker modal * return value from picker * accept native error * clean up data source * add tests for error states * make clipboard local storage manager * add clip entry entity type * create unique in scaffold * add clipboard entry item data * align naming * move around * name alignment * fix imports * fix missing entityType * clean up * use picker input context * remove unused context * Update clipboard.context.ts * map to item model * poc paste property action * register copy/paste as kinds * lint fix * add tests * rename test * add repository tests * register delete clipboard action + enable action dropdown outside of context menu * remove notifcation * export entity type * temp use repo instead of context * delete unused copy property action * make data source non breaking * Update vite.config.ts * add icons for clipboard copy, paste + entry * remove unused * return if there is no property value * add kind interfaces * pass entry type for copy and paste * register clipboard for block list * implement filter on entry type * delete unused context * remove references * rename data to value and don't force an array * make icons and single value * allow to add create and update dates for clipboard entries * use clipboard icon * add create and update dates * export constants * don't set as an array * reload picker content * add copy to clipboard button to block list entry * make picker element * allow to pick multiple * remove generic block list clipboard actions * Revert "remove generic block list clipboard actions" This reverts commit 6ea65a0. * add get methods * wip construct block clipboard entry value * add method to get exposes + add jsdocs * add expose * remove todo + add jsdocs * move clipboard out of core package * add package files * load package again * render entry icon * render correct icon * remove clipboard from core vite.config * Update package-lock.json * wip copy/paste resolvers * allow multiple accepted entry types * move logic to resolvers * transforming clipboard block value to fit block list * wip copy/paste resolvers * clean up * remove unused * fix missing exports * fix tests * return clipboard entry unique from modal * Update block-list-entries.context.ts * clipboard feature: clipboard property value cloner (#17824) * restructure of property package * content data merge controller tests * deprecate meta from propertyValueResolver * temp work * temp * poc * rename to cloner * stached block value cloner work * block list implementation * correct property value implementation * RTE Block Property Value Cloner * Block Grid Value Cloner * update with comments * try out cloner * wip translators * Revert "delete unused context" This reverts commit ec31ae5. * move translator + cloner logic to context * clean up * implement read from clipboard in block list property editor * remove debugger * values array * handle paste * Update types.ts * move files * Update clipboard-local-storage.manager.ts * set both create and update date when creating a clipboard entry * align naming * handle paste * clean up + wip block grid translators * updates types * add grid block copy translator * only allow paste translator to handle a single value * align copy and paste translators * remove debugger * move to folders * add block const * rename * add tests * Update index.ts * use correct type * add tests for UmbBlockListToBlockClipboardCopyTranslator * fix tests * add translator tests * add tests * organize * organize * clean up translator tests * align naming * remove unused button * only render copy property action if property has a value * use constants * copy single grid block * get block grid property value from clipboard entry * add clear method to extension registry + add js docs * Update index.ts * add tests for copy value resolver * add icon for clipboard * use clipboard icon in modal * add tests * remove unused setting * fix log * only create array once * filter for supported paste translators * use write method instead of duplicating the code * add condition config type * use config type * Update manifests.ts * add support for multi picker * move multiple look up logic to context * add js docs * add js docs * remove unused * remove unused * remove unused * implement paste translator filtering for block catalogue modal * temp color translator * adding a UmbPropertyValueDataPotentiallyWithEditorAlias * simplify observer * append user unique to local storage key * remove temp color picker clipboard implementations * more explicit extension type name * more renaming * type specifications * fix test and missing type * more types for test * renaming of paste translators * rename folder * rename value resolvers * correct variable name * wip tests for clipboard context * clean up tests correctly * add more tests for clipboard context * Update clipboard.context.test.ts * use after each for clean up * fix test that times out * correct name * optimize * remove webkit * newest first when picking * use fingerprint local storage key to obfuscate user id * rename method * use const * set content max length * return object including the selection uniques * show confirm dialog before pasting value * only show confirm dialog if there is a value * Feature: clipboard block insert (#17935) * insert methods * fix originData * move logic to base class * progress on Grid and RTE * correct for Block Grid paste implementation * update async across * remove expose from block clipboard entry model * remove expose from grid block clipboard entry * remove todo * wip move value expand responsibility * wip split clipboard context * experiment with an extendable property context * create propertyContexts + proxy events * rename methods * move proxy to context + update grid copy logic * split tests * remove unused * add property context extension type * fix tests * fix tests * reorganize * Update clipboard.property-context.ts * use context * register property context clipboard kind * register for block grid * remove redundant code * rename to replace * Revert "rename to replace" This reverts commit eb0535e. * rename prop * rename label * improve block clean-up abilities * Update rte-base.element.ts * make local get of clipboard context * add asyncFilter option to the type * add is compatible method to the interface * support asyncFilter in picker * add compatability check for block list * more explicit name * wip implementation of filter * add compatability checks * add temp types * add clipboard filtering for grid and list * lint corrections --------- Co-authored-by: Niels Lyngsø <[email protected]> Co-authored-by: Niels Lyngsø <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extension Type and Controller for Property Value Cloner.
Plus implementation for Block List Property Editor.