Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Published Document Pending Changes #17812

Merged
merged 83 commits into from
Dec 18, 2024

remove client test thats doesn't do anything but trouble

545b3c9
Select commit
Loading
Failed to load commit list.
Merged

Feature: Published Document Pending Changes #17812

remove client test thats doesn't do anything but trouble
545b3c9
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (v15/dev) failed Dec 18, 2024 in 1m 9s

CodeScene PR Check

❌ Code Health Quality Gates: FAILED

Change in average Code Health of affected files: -0.05 (9.62 -> 9.57)

  • Declining Code Health: 9 findings(s) 🚩
  • Improving Code Health: 3 findings(s) ✅
  • Affected Hotspots: 1 files(s) 🔥

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Code Duplication document-publishing.workspace-context.ts
  • Overall Code Complexity document-publishing.workspace-context.ts
  • Complex Method document-publishing.workspace-context.ts: UmbDocumentPublishingWorkspaceContext.publishWithDescendants
  • Complex Method document-publishing.workspace-context.ts: UmbDocumentPublishingWorkspaceContext.schedule
  • Complex Method document-publishing.server.data-source.ts: UmbDocumentPublishingServerDataSource.published
  • Complex Method document-publishing.workspace-context.ts: UmbDocumentPublishingWorkspaceContext.handleSaveAndPublish
  • Complex Method document-published-pending-changes.manager.ts: UmbDocumentPublishedPendingChangesManager.process
  • Complex Conditional document-workspace-split-view-variant-selector.element.ts: UmbDocumentWorkspaceSplitViewVariantSelectorElement.getVariantState
  • Complex Method document-publishing.workspace-context.ts: UmbDocumentPublishingWorkspaceContext.performSaveAndPublish

✅ Improving Code Health:

  • Complex Method document-workspace.context.ts: UmbDocumentWorkspaceContext.publishWithDescendants 🔥
  • Complex Method document-workspace.context.ts: UmbDocumentWorkspaceContext.handleSaveAndPublish 🔥
  • Overall Code Complexity document-workspace-view-info.element.ts

Annotations

Check notice on line 320 in src/Umbraco.Web.UI.Client/src/packages/documents/documents/workspace/document-workspace.context.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v15/dev)

✅ No longer an issue: Complex Method 

UmbDocumentWorkspaceContext.publishWithDescendants is no longer above the threshold for cyclomatic complexity

Check notice on line 256 in src/Umbraco.Web.UI.Client/src/packages/documents/documents/workspace/document-workspace.context.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v15/dev)

✅ No longer an issue: Complex Method 

UmbDocumentWorkspaceContext.handleSaveAndPublish is no longer above the threshold for cyclomatic complexity

Check warning on line 173 in src/Umbraco.Web.UI.Client/src/packages/documents/documents/publishing/repository/document-publishing.server.data-source.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v15/dev)

❌ New issue: Complex Method 

UmbDocumentPublishingServerDataSource.published has a cyclomatic complexity of 13, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 55 in src/Umbraco.Web.UI.Client/src/packages/documents/documents/workspace/document-workspace-split-view-variant-selector.element.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v15/dev)

❌ New issue: Complex Conditional 

UmbDocumentWorkspaceSplitViewVariantSelectorElement.getVariantState has 1 complex conditionals with 2 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.

Check warning on line 64 in src/Umbraco.Web.UI.Client/src/packages/documents/documents/publishing/pending-changes/document-published-pending-changes.manager.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v15/dev)

❌ New issue: Complex Method 

UmbDocumentPublishedPendingChangesManager.process has a cyclomatic complexity of 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 122 in src/Umbraco.Web.UI.Client/src/packages/documents/documents/publishing/workspace-context/document-publishing.workspace-context.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v15/dev)

❌ New issue: Code Duplication 

The module contains 2 functions with similar structure: UmbDocumentPublishingWorkspaceContext.publishWithDescendants,UmbDocumentPublishingWorkspaceContext.schedule. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.

Check warning on line 179 in src/Umbraco.Web.UI.Client/src/packages/documents/documents/publishing/workspace-context/document-publishing.workspace-context.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v15/dev)

❌ New issue: Complex Method 

UmbDocumentPublishingWorkspaceContext.publishWithDescendants has a cyclomatic complexity of 15, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 122 in src/Umbraco.Web.UI.Client/src/packages/documents/documents/publishing/workspace-context/document-publishing.workspace-context.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v15/dev)

❌ New issue: Complex Method 

UmbDocumentPublishingWorkspaceContext.schedule has a cyclomatic complexity of 14, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 259 in src/Umbraco.Web.UI.Client/src/packages/documents/documents/publishing/workspace-context/document-publishing.workspace-context.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v15/dev)

❌ New issue: Complex Method 

UmbDocumentPublishingWorkspaceContext.handleSaveAndPublish has a cyclomatic complexity of 13, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 286 in src/Umbraco.Web.UI.Client/src/packages/documents/documents/publishing/workspace-context/document-publishing.workspace-context.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v15/dev)

❌ New issue: Complex Method 

UmbDocumentPublishingWorkspaceContext.performSaveAndPublish has a cyclomatic complexity of 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 1 in src/Umbraco.Web.UI.Client/src/packages/documents/documents/publishing/workspace-context/document-publishing.workspace-context.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v15/dev)

❌ New issue: Overall Code Complexity 

This module has a mean cyclomatic complexity of 5.81 across 16 functions. The mean complexity threshold is 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.

Check notice on line 1 in src/Umbraco.Web.UI.Client/src/packages/documents/documents/workspace/views/info/document-workspace-view-info.element.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v15/dev)

✅ No longer an issue: Overall Code Complexity 

The mean cyclomatic complexity in this module is no longer above the threshold
View more details on CodeScene Delta Analysis