Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V15: Handle empty permissions #17801

Merged
merged 6 commits into from
Dec 17, 2024
Merged

V15: Handle empty permissions #17801

merged 6 commits into from
Dec 17, 2024

Conversation

Zeegaan
Copy link
Member

@Zeegaan Zeegaan commented Dec 12, 2024

Notes

  • Handle empty granular permissions for user groups.

How to test

  • Create a document type with allowed as root set to true
  • Create some content with that doc type
  • Go to User -> User groups, select a user group
  • under granular permission, select the content, but don't select any permissions
  • Save and refresh the page
  • The granular permissions should persist

@Zeegaan Zeegaan marked this pull request as ready for review December 12, 2024 11:52
kjac
kjac approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@kjac kjac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@Zeegaan Zeegaan merged commit 545d64d into v15/dev Dec 17, 2024
27 checks passed
@Zeegaan Zeegaan deleted the v15/bugfix/fix-empty-granular-permissions branch December 17, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjac kjac kjac approved these changes

Assignees
No one assigned
Labels
release/15.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zeegaan @kjac