Feature: Adding first round of data marks #17755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We would like to use : instead of slashes, for button it should be action:create or action:open and so on, inputs should be input:name input:property-name and so on aswell |
nhudinh0309
requested changes
Dec 13, 2024
src/Umbraco.Web.UI.Client/src/packages/core/section/section-sidebar/section-sidebar.element.ts
Outdated
Show resolved
Hide resolved
...t/src/packages/data-type/workspace/views/details/data-type-details-workspace-view.element.ts
Show resolved
Hide resolved
...t/src/packages/data-type/workspace/views/details/data-type-details-workspace-view.element.ts
Show resolved
Hide resolved
…debar/section-sidebar.element.ts Co-authored-by: Nhu Dinh <[email protected]>
|
I looked at the code changes and the look all good :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding data-marks, mainly with the focus of providing hooks for tests to query.
Please verify the naming and structure and provide feedback on how this would work for tests.