Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V15: Clear elements cache instead of refreshing it #17708

Merged
merged 1 commit into from
Dec 3, 2024

Clear elements cache instead of refreshing it

6b3debe
Select commit
Loading
Failed to load commit list.
Merged

V15: Clear elements cache instead of refreshing it #17708

Clear elements cache instead of refreshing it
6b3debe
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (release/15.1) succeeded Dec 3, 2024 in 34s

CodeScene PR Check

Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.71 (8.68 -> 9.39)

  • Improving Code Health: 3 findings(s) ✅

View detailed results in CodeScene

Details

✅ Improving Code Health:

  • Complex Method CacheRefreshingNotificationHandler.cs: RefreshElementsCacheAsync
  • Complex Conditional CacheRefreshingNotificationHandler.cs: RefreshElementsCacheAsync
  • Bumpy Road Ahead CacheRefreshingNotificationHandler.cs: RefreshElementsCacheAsync

Annotations

Check notice on line 84 in src/Umbraco.PublishedCache.HybridCache/NotificationHandlers/CacheRefreshingNotificationHandler.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (release/15.1)

✅ No longer an issue: Complex Method

RefreshElementsCacheAsync is no longer above the threshold for cyclomatic complexity

Check notice on line 83 in src/Umbraco.PublishedCache.HybridCache/NotificationHandlers/CacheRefreshingNotificationHandler.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (release/15.1)

✅ No longer an issue: Complex Conditional

RefreshElementsCacheAsync no longer has a complex conditional

Check notice on line 84 in src/Umbraco.PublishedCache.HybridCache/NotificationHandlers/CacheRefreshingNotificationHandler.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (release/15.1)

✅ No longer an issue: Bumpy Road Ahead

RefreshElementsCacheAsync is no longer above the threshold for logical blocks with deeply nested code