Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V15: Show a loader during the login procedures rather than oddly styled content #17618

Merged
merged 4 commits into from
Nov 25, 2024

Conversation

iOvergaard
Copy link
Contributor

@iOvergaard iOvergaard commented Nov 22, 2024

Description

Fixes #17453

  • Shows only a loader for a normal login flow
  • Shows the umb-app-error component only if the flow fails (either in the main window or a popup)
  • Fixes an error where hasOwnOpener did not work (at least not on the Vite server)

How to test

  1. Log in as normal and verify that you do not see a "flash of oddly styled content" but instead a uui-loader (you probably have to slow down the network requests)
  2. Try and force a session timeout, e.g. by changing the access_token in Local Storage and performing some request, e.g. going to a content page
  3. You should now see the login timeout overlay
  4. Verify that the popup is closed after login and that you only see a loader inside the popup

Hint: You can force the "login landing page" by going to https://localhost:44339/umbraco/oauth_complete and appending ?code=test to see the success variant and omitting the ?code parameter to see the failure variant.

if the flow fails, the app-error component will be shown, or if the flow is initialised inside a popup (i.e. the session was lost)
…hname

it should work better by checking the `startsWith` comparing the pathname, and besides, it seems to work better for the understanding of the function to inverse the true/false check
@iOvergaard iOvergaard changed the title v15/feature/login-default-flow V15: Show a loader during the login procedures rather than oddly styled content Nov 22, 2024
Copy link
Member

@leekelleher leekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out, works as expected! 🚀

@leekelleher leekelleher merged commit 2383fbc into v15/dev Nov 25, 2024
18 of 19 checks passed
@leekelleher leekelleher deleted the v15/feature/login-default-flow branch November 25, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants