Media Picker: only allow navigating to folders/media with children + other fixes #17617
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (v15/dev)
succeeded
Nov 25, 2024 in 1m 7s
CodeScene PR Check
✅ Code Health Quality Gates: OK
Change in average Code Health of affected files: -0.03 (9.81 -> 9.77)
- Declining Code Health: 2 findings(s) 🚩
View detailed results in CodeScene
Absence of Expected Change Pattern
- Umbraco-CMS/src/Umbraco.Web.UI.Client/src/external/backend-api/src/types.gen.ts is usually changed with: Umbraco-CMS/src/Umbraco.Web.UI.Client/src/external/backend-api/src/services.gen.ts
Details
🚩 Declining Code Health (highest to lowest):
- Complex Conditional media-picker-modal.element.ts: UmbMediaPickerModalElement.renderBreadcrumb
- Complex Method media-table-collection-view.element.ts: UmbMediaTableCollectionViewElement.createTableItems
Annotations
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v15/dev)
❌ New issue: Complex Conditional
UmbMediaPickerModalElement.renderBreadcrumb has 1 complex conditionals with 2 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v15/dev)
❌ Getting worse: Complex Method
UmbMediaTableCollectionViewElement.createTableItems increases in cyclomatic complexity from 9 to 11, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Loading