Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aligning Settings welcome dashboard headlines #17609

Merged

Conversation

madsrasmussen
Copy link
Contributor

We are currently using h1 for headlines in the settings welcome dashboard. I have updated these to use the box headline prop instead to keep the UI consistent.

Updated dashboard
Screenshot 2024-11-21 at 14 39 29

`rel=noopener` is automatically implemented
by the browser for `target=_blank` links.
Copy link
Member

@leekelleher leekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

I've added a few amends: updated links, CSS tweak and removed the rel=noopener (as modern browsers automatically implement this for target=_blank).

@leekelleher leekelleher merged commit 44384c0 into v15/dev Nov 21, 2024
7 of 10 checks passed
@leekelleher leekelleher deleted the v15/bugfix/align-settings-welcome-dashboard-headlines branch November 21, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants