Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes routing issues #17572

Merged
merged 4 commits into from
Nov 26, 2024
Merged

Fixes routing issues #17572

merged 4 commits into from
Nov 26, 2024

Conversation

bergmania
Copy link
Member

Fixes #17548

Description

This fixes two issues with routing

  1. If multiple domains was assigned with the same culture (V15 - Multiple hostnames per culture per node causes backoffice crash #17548) it exploded when showing the urls in backoffice
  2. If you have multiple roots (and HideTopLevelNodeFromPath = true), then only children of the first root respected the HideTopLevelNodeFromPath.

Tests

  1. Assign multiple domains with the same culture to one item, and ensure it can still list urls.
  2. Setup multiple roots and have children of each with the same name. - Verify only the top one is routable (like in v13)
  • Also just be creative in weird cases - all test is welcome :)

@Migaroez
Copy link
Contributor

With the following setup
image

  • DomainOne having the /d-one/ hostname assigned
  • DomainTwo having the /d-two/ hostname assigned
  • "HideTopLevelNodeFromPath": false configured

The following discrepancies between v13.5.2 and v15(this PR) are found

  • Root
    • V13: /
    • V15: /root
  • Root => child
    • V13: /child
    • V15: /root/child
  • Other => Child
    • V13: This document is published but its URL would collide with content /Root/Child (id=1058)
    • V15: /other/child

@Migaroez Migaroez merged commit 29837fe into v15/dev Nov 26, 2024
19 of 20 checks passed
@Migaroez Migaroez deleted the v15/bugfix/routing-for-second-roots branch November 26, 2024 08:55
Migaroez pushed a commit that referenced this pull request Nov 26, 2024
* Child of second root should also hide root path and backoffice needs to show all domains for each language.

* Fixes routing issues based on findings #17572 (comment)

* Revert "Fixes routing issues based on findings #17572 (comment)"

This reverts commit ba7fb5c.

* Fix urls of descendants of non-first roots do not show the root urlsegment when HideTopLevel is true
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants