Feature: Block workspace modal size from block type #17501
+81
−30
Merged
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (v15/dev)
failed
Nov 13, 2024 in 41s
CodeScene PR Check
❌ Code Health Quality Gates: FAILED
Change in average Code Health of affected files: +0.02 (8.32 -> 8.34)
- Declining Code Health: 1 findings(s) 🚩
- Improving Code Health: 3 findings(s) ✅
- Affected Hotspots: 1 files(s) 🔥
Details
🚩 Declining Code Health (highest to lowest):
- Complex Method block-workspace.context.ts: UmbBlockWorkspaceContext.constructor 🔥
✅ Improving Code Health:
- Overall Code Complexity block-workspace.context.ts 🔥
- Complex Method modal.context.ts: constructor
- Overall Code Complexity modal.context.ts
Annotations
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v15/dev)
❌ Getting worse: Complex Method
UmbBlockWorkspaceContext.constructor increases in cyclomatic complexity from 17 to 20, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v15/dev)
✅ Getting better: Overall Code Complexity
The mean cyclomatic complexity decreases from 5.41 to 5.39, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v15/dev)
✅ Getting better: Complex Method
constructor decreases in cyclomatic complexity from 24 to 22, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check notice on line 1 in src/Umbraco.Web.UI.Client/src/packages/core/modal/context/modal.context.ts
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v15/dev)
✅ No longer an issue: Overall Code Complexity
The mean cyclomatic complexity in this module is no longer above the threshold
Loading