Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V15: Bugfix: Add "Not Found" empty state to detail workspaces #17489

Merged
merged 47 commits into from
Nov 19, 2024

Conversation

madsrasmussen
Copy link
Contributor

@madsrasmussen madsrasmussen commented Nov 11, 2024

This pull request introduces a "Not Found" view that will be displayed when an entity is not in the detail store. This state occurs in several scenarios:

  • When you navigate to a workspace with a unique that can't be found on the server.
  • When you delete the same entity from the menu while already in the workspace
  • When any other process deletes the entity (signal r etc.)

The core functionality is built into the "UmbEntityDetailWorkspaceBase," which subscribes to changes in the detail store. If an entity is removed from the store, the data will be cleared in the workspace context, and a not found view will be displayed.

I have added a couple of additional features to complete this feature:

  • A loading state for when the entity data is being scaffolded or loaded.
  • A new "umb-entity-detail-workspace-editor" element that implements the not-found view + renders the workspace entity action at the right time (only when an entity is fully created).

This feature is currently implemented in the following workspaces. However, we still need to align some of the remaining workspaces to ensure it work in all cases:

  • Data Type
  • Language
  • Webhook
  • Dictionary
  • Template
  • Script
  • Partial View
  • User
  • User Group
  • Member Group
Screenshot 2024-11-13 at 10 20 31

@nielslyngsoe nielslyngsoe merged commit 310ccdc into v15/dev Nov 19, 2024
7 of 10 checks passed
@nielslyngsoe nielslyngsoe deleted the v15/bugfix/handle-deleted-open-workspace-entity branch November 19, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants