-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V15: Bugfix: Add "Not Found" empty state to detail workspaces #17489
Merged
nielslyngsoe
merged 47 commits into
v15/dev
from
v15/bugfix/handle-deleted-open-workspace-entity
Nov 19, 2024
Merged
V15: Bugfix: Add "Not Found" empty state to detail workspaces #17489
nielslyngsoe
merged 47 commits into
v15/dev
from
v15/bugfix/handle-deleted-open-workspace-entity
Nov 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gfix/handle-deleted-open-workspace-entity
nielslyngsoe
deleted the
v15/bugfix/handle-deleted-open-workspace-entity
branch
November 19, 2024 08:14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a "Not Found" view that will be displayed when an entity is not in the detail store. This state occurs in several scenarios:
The core functionality is built into the "UmbEntityDetailWorkspaceBase," which subscribes to changes in the detail store. If an entity is removed from the store, the data will be cleared in the workspace context, and a not found view will be displayed.
I have added a couple of additional features to complete this feature:
This feature is currently implemented in the following workspaces. However, we still need to align some of the remaining workspaces to ensure it work in all cases: