Bugfix: Document Workspace Info Links error #17483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures that `_unique` has value. This was previously throwing an error, but given how `observeMultiple` works, it is expected that `_unique` may be `undefined` when navigating away from the Info view.
madsrasmussen
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When navigating away from the Document Workspace Info view, the Links component will throw an error as the
_uniqueisundefined.Given how
observeMultipleworks, it should be expected that_uniquemay beundefinedwhen navigating away from the Info view, so rather than throw a console error, we don't attempt to request the link URLs.