Support limited language access at block level #17322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#17333) * Remove obsolete ctor * Add explanatory comment * Set AllowEditInvariantFromNonDefault to true on tests * Refactor to account for merge and default language * Merge invariant values on top of the already merged values * Add integration test to prove invariant merging --------- Co-authored-by: kjac <[email protected]>
bergmania
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
This PR adds block level handling for users with limited language access.
It works the same as on document level: All block level changes are rolled back for the languages the current user does not have access to update.
Notice how the app setting
Umbraco:CMS:Content:AllowEditInvariantFromNonDefaultalso affects this: If that setting isfalse, the current user must have access to the default language to make changes to invariant properties.Testing this PR
Attempt to update block level variant content for languages which the current user does not have access to. Those changes should not be persisted.
You may need to use Swagger for a trustworthy result, as the back-office client is yet to be updated for this.