Do not rely on NuCache to do key/id lookups #17291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great and tests out great too; I have tested both attended and unattended upgrades. However, the E2E tests continue to fail when I restart them. Can you have a look? |
bergmania
deleted the
v14/hotfix/17182-No-not-rely-on-nucache-for-id-to-key-lookups
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17182
Description
Doing migrations we need to lookup ids for keys and keys for ids. The IIdKeyMap is implemented using Nucache, and if any change to the nucache content happens, it will fail.
This is the safer approach as the comment also says. This changes as already been made in V15
Test