Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notification alias to document notifications endpoint output #17028

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

kjac
Copy link
Contributor

@kjac kjac commented Sep 9, 2024

Prerequisites

  • I have added steps to test this contribution in the description below

Description

To ease localization of the "Document notifications" dialog, the document notification aliases have been added to the output of the supporting endpoint.

Testing this PR

Verify that the output from the document notifications endpoint contains an alias for each notification type.

Copy link
Contributor

@iOvergaard iOvergaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iOvergaard iOvergaard merged commit 19c5711 into v15/dev Sep 17, 2024
16 of 17 checks passed
@iOvergaard iOvergaard deleted the v15/fix/action-alias-for-notifications branch September 17, 2024 08:58
@iOvergaard
Copy link
Contributor

Picked for V14 with e6f3790

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants