Remove favicon from dotnet templates

[callumbwhyte]

Following a discussion about websites accidentally appearing in Google with an Umbraco favicon, I noted that Umbraco's dotnet templates automatically include this.

It's something I see time and again on our own + inherited projects, that people don't realise there is a default favicon.ico file shipped within the template. This makes it very easy to overlook and deploy a new Umbraco site with the Umbraco logo as a favicon.

I can't really see any good reason for this, other than for the wwwroot folder to appear in the project... which there must surely be better ways of doing!

This change seems like it could be backported to v13 also without any issues 🤞

[github-actions]

Hi there @callumbwhyte, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

• It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
• The automated tests all pass (see "Checks" tab on this PR)
• The level of security for this contribution is the same or improved
• The level of performance for this contribution is the same or improved
• Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
• If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
• 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[georgebid]

Thanks for the PR @callumbwhyte! We'll get this reviewed soon 💯

[georgebid]

Hey @callumbwhyte, HQ are happy to go ahead with this PR, but we'll also need to remove the file from the repo, would you be able to make this change and update your PR? 😄 Then the favicon will be gone for good 💯

[callumbwhyte]

Heya @georgebid,

I didn't remove the favicon file itself because the Umbraco.Web.UI project that it is being copied from is the project that runs when people run the source. There are other things in that project purely for running the source locally (e.g. this composer) that don't get included in the template either.

If you still want me to go ahead and remove the physical file please let me know!

[georgebid]

@callumbwhyte good point, ignore me 😺 I'll get this reviewed and merged soon!

[bergmania]

FYI, the fact that wwwroot is not there, means you force people to do a restart after first boot, to allow static files to be accessible.

Thereby installing a starter kit on first boot, is not really working anymore. Maybe there is better ways, but empty folders are tricker with git and folder creation becomes tricker with multi OS Support