V15: Update to dotnet 9

[Zeegaan]

Notes

• Had to rename TrimStart & TrimEnd, as they are now implemented by Microsoft, and the behavior differs from ours.
  • The Umbraco versions are now named TrimStartExact and TrimEndExact
• Updates dotnet verison to dotnet9
• Updates nuget packages to their respective dotnet 9 version
• Had to update Umbraco.Code to 2.2 aswell, as it used the Microsoft.CodeAnalysis package, and thus we couldn't update that.

How to test

Ensure both templates & source code work with dotnet 9

• Download dotnet 9 preview here: https://dotnet.microsoft.com/en-us/download/dotnet/9.0
• In the root of the project, run dotnet pack -o nuget
• Go to the nuget folder cd nuget
• Copy the path of that folder, and then run dotnet nuget add source [PATH TO NUGET FOLDER HERE]
• Install the templates, take note of the version of the templates nupkg in the nuget folder dotnet new install Umbraco.Templates::[version of templates here]
• Create a new umbraco project with the new template dotnet new umbraco -n "MyTestProject"
• Run the project and assert it works 👍

[elit0451]

Can you have a look at the pipelines and update the <TargetFramework> to net9.0 in the csproj's of our dotnet new templates? And the .template.config/template.json has also mentions of net8.0

[ronaldbarendse]

I've had a quick look and added my comments/suggestions 😄

Seems like we can actually do more cleaning up of the StringExtensions class, as there's a lot of unused methods or ones that are very specific to our own codebase and could therefore be changed to internal...

[Zeegaan]

@ronaldbarendse Cleanup sounds great, but is out of scope for this PR IMO, we can always make a separate one with cleanups 👍

[elit0451]

Looks good and tests out good 💪 Merging

[vsilvar]

@Zeegaan Please consider documenting the renaming of the TrimStart and TrimEnd functions as a breaking change.
As this is actually quite a tricky change (outside of Umbraco's control of course), because any consumer currently using the extension methods, will now start using the new Microsoft implementation without their knowledge, and as the behavior differs, this will most likely result in bugs.

FYI @nul800sebastiaan

[nul800sebastiaan]

It's documented

[vsilvar]

Well, technically yes, but not really.
It's not directly mentioned in the Umbraco 15 blog post nor in breaking changes documentation.
And even in the Github release notes, it just mentions this PR as: Update to dotnet 9

Not sure if my description of the issue was clear, but just by updating Umbraco, and not changing any code (not even usings):

"FooBarApiOptions".TrimEnd("Options")

Previous result: FooBarApi
New result: FooBarA

[nul800sebastiaan]

Yikes! I see that .NET 9 seems to split it into chars that need to be trimmed from the end, which is why that p and i from Api are also removed. A much more significant change than I thought it would be.

I'd say this is a good suggestion for both the docs (@sofietoft) and the blog post for the final release (@bergmania) 👍

[ronaldbarendse]

@bergmania @nul800sebastiaan I just updated to the final .NET 9 GA and noticed the overloads with ReadOnlySpan<char> have been removed: https://learn.microsoft.com/en-us/dotnet/core/compatibility/core-libraries/9.0/string-trim.

I'd suggest renaming our extension methods back to TrimStart() and TrimEnd() to avoid unnecessary breaking changes (at least when going from stable to stable versions)!

[nul800sebastiaan]

This has been reverted here: b9b7cb6