-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle external authentication providers #13487
Handle external authentication providers #13487
Conversation
|
||
private async Task<IActionResult> AuthorizeInternal(OpenIddictRequest request) | ||
{ | ||
// TODO: ensure we handle sign-in notifications for internal logins. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This TODO has been added to the backlog item "New login screen" (23812)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, and tests out good 🎉 👍
And thank you for the great testing instructions 🙌
* update marketplace url to its final, live url * Added various Block Grid translations (EN & NL) (#13488) * Added various translations * Added another translation * Change request * Revert breaking changes adding IContextCache to deploy connectors (#13489) * Remove breaking changes in Deploy connector interfaces * Add extension methods for calling the new interface methods in a backwards-compatible way * Create and pack empty file to add TFM dependency (#13475) * Change login image to new SVG. (#13493) * Only add global usings when ImplicitUsings is enabled (#13491) * bump to rc6 * V11: Allow changing logging directory from configuration (#13485) * Allow changing logging directory from configuration * Clean up * Missing return statement * Apply suggestions from code review Co-authored-by: Nikolaj Geisle <[email protected]> * Update src/Umbraco.Core/Constants-SystemDirectories.cs Co-authored-by: Nikolaj Geisle <[email protected]> Co-authored-by: Nikolaj Geisle <[email protected]> * Move login.svg file * Make sure contexbar fits within the available space (#13467) * Make sure contexbar fits within the available space * Ensuring context bar moves above, no matter size of it. * Fixing apperance of connection-fixers * Info panes not loading prerequisites (#13486) * load relations immediately on init and remove call to non-existing function `appTabChange` on destroy * load relations immediately on init and remove now not-used eventsService * do not set layout gaps (#13496) * Nuget updates (#13478) * Updated nuget packages * Remove npoco update Co-authored-by: nikolajlauridsen <[email protected]> * Nuget updates (#13478) * Updated nuget packages * Remove npoco update Co-authored-by: nikolajlauridsen <[email protected]> * Bump version to final * V11/cherry pick flaky test (#13506) * V10/feature/fixing flaky acceptance test (#13473) * Bumped version * Handle external authentication providers (#13487) Co-authored-by: Jacob Overgaard <[email protected]> Co-authored-by: Corné Hoskam <[email protected]> Co-authored-by: Ronald Barendse <[email protected]> Co-authored-by: Niels Lyngsø <[email protected]> Co-authored-by: Bjarke Berg <[email protected]> Co-authored-by: Nikolaj Geisle <[email protected]> Co-authored-by: nikolajlauridsen <[email protected]> Co-authored-by: Andreas Zerbst <[email protected]>
Prerequisites
Description
This PR adds handling for external authentication providers for the new backoffice.
Testing this PR
Setup
First and foremost you need an external authentication provider configured. For testing we'll use GitHub.
AspNet.Security.OAuth.GitHub
in your site.GitHubAuthenticationExtensions
:.AddGitHubAuthentication()
toConfigureServices(IServiceCollection services)
inStartup
.Testing local login
Verify that you can still login to the new backoffice using your local account.
https://localhost:44331/umbraco/management/api/v1.0/security/back-office/authorize?client_id=umbraco-back-office&scope=offline_access&response_type=code&code_challenge=WZRHGrsBESr8wYFZ9sx0tPURuZgG2lmzyvWpwXPKz8U&code_challenge_method=S256
code
in the URL (this means the login was successful):Testing remote login (implicitly)
https://localhost:44331/umbraco/management/api/v1.0/security/back-office/authorize?client_id=umbraco-back-office&scope=offline_access&response_type=code&code_challenge=WZRHGrsBESr8wYFZ9sx0tPURuZgG2lmzyvWpwXPKz8U&code_challenge_method=S256
code
in the URL (same as above)Testing remote login (explicitly)
https://localhost:44331/umbraco/management/api/v1.0/security/back-office/authorize?client_id=umbraco-back-office&scope=offline_access&response_type=code&code_challenge=WZRHGrsBESr8wYFZ9sx0tPURuZgG2lmzyvWpwXPKz8U&code_challenge_method=S256&identity_provider=Umbraco.GitHub
Testing Swagger access with local login
https://localhost:44331/umbraco/swagger/index.html
Testing Swagger access with external login
https://localhost:44331/umbraco/swagger/index.html