Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V15 User Client Credentials: Able to add an credential with invalid id #17506

Open
nhudinh0309 opened this issue Nov 12, 2024 · 2 comments
Open
Labels
release/15.1.0 state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks type/bug

Comments

@nhudinh0309
Copy link
Contributor

nhudinh0309 commented Nov 12, 2024

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

15.0.0-rc4

Bug summary

When I tried to add client credentials for an API user with a long id, an error message was displayed. However, if I update the ID field with a valid value and click the 'Save' button, two credentials are created: one with the long name and another with the valid name.****

Specifics

No response

Steps to reproduce

  1. Create an API user
  2. Add a client credential for the user
  3. Enter the invalid id (ex: a long id)
  4. Click "Create' button
  5. The error displays but the Create client credential form still displays, so enter another valid id
  6. Click "Create" button

Expected result / actual result

Only one client credential with valid id is created. But currently there are 2 client credentials created

RC4_UserClientCredentials_Issue.mp4

This item has been added to our backlog AB#45947

@nhudinh0309 nhudinh0309 changed the title V15 RC4 User Client Credentials: Able to add an credential with invalid id V15 User Client Credentials: Able to add an credential with invalid id Nov 12, 2024
@bergmania bergmania self-assigned this Nov 14, 2024
bergmania added a commit that referenced this issue Nov 14, 2024
Now the validation of ClientId has a max of 255 characters
@bergmania bergmania added state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks release/15.1.0 and removed state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks area/frontend area/backend affected/v15 labels Nov 14, 2024
@bergmania bergmania removed their assignment Nov 14, 2024
nikolajlauridsen pushed a commit that referenced this issue Nov 15, 2024
Now the validation of ClientId has a max of 255 characters
@nikolajlauridsen
Copy link
Contributor

Fixed in #17536

@nielslyngsoe
Copy link
Member

This issue is still present in 15.1-rc2 — the issue will be fixed in the coming sprint.

@nielslyngsoe nielslyngsoe added the state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/15.1.0 state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks type/bug
Projects
None yet
Development

No branches or pull requests

4 participants