15rc: Creating new doc type properties sort order doesn't count existing properties

[cheeseytoastie]

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

15.1.0-rc1.preview.37

Bug summary

Adding doc type properties to an existing doc type with 2+ existing properties puts them always in position 1 not at the bottom as expected.

Specifics

Tested on firefox - same as Chrome.

Steps to reproduce

If you create a new doctype with a single tab and create 2+ properties.

Save the doc type and reload.

Add a new doc type property - the new property is added second in the list of existing properties and not at the bottom.

It appears to be given sort order = 0, and is positioned after the first, existing 0.

This might have been missed in testing if that you have only one existing property it does go to the bottom as expected, the problem is only visible with more than 1 existing property.

Expected result / actual result

I would expect new properties to be added to the bottom as per previous versions until you change the sort order.

[github-actions]

Hi there @cheeseytoastie!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

• We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
• If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
• We'll replicate the issue to ensure that the problem is as described.
• We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[cheeseytoastie]

I have a fix for this - I think I need to submit this to the Umbraco.Backoffice repo.