Fix has pending package migrations (#17423)

* update submodule * update submodule * Reintroduce a favicon (#17422) * Fixes issue where package name was compared to package id, so packages had pending migrations from the management api endpoint, without actually have it. --------- Co-authored-by: Niels Lyngsø <[email protected]>
umbraco · Nov 6, 2024 · 0bf2fbc · 0bf2fbc
1 parent 21a3c31
commit 0bf2fbc
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/Umbraco.Infrastructure/Services/Implement/PackagingService.cs b/src/Umbraco.Infrastructure/Services/Implement/PackagingService.cs
@@ -382,16 +382,16 @@ public Task<PagedModel<InstalledPackage>> GetInstalledPackagesFromMigrationPlans
             _keyValueService.FindByKeyPrefix(Constants.Conventions.Migrations.KeyValuePrefix);
 
         InstalledPackage[] installedPackages = _packageMigrationPlans
-            .GroupBy(plan => plan.PackageName)
+            .GroupBy(plan => (plan.PackageName, plan.PackageId))
             .Select(group =>
             {
                 var package = new InstalledPackage
                 {
-                    PackageName = group.Key,
+                    PackageName = group.Key.PackageName,
                 };
 
                 var currentState = keyValues?
-                    .GetValueOrDefault(Constants.Conventions.Migrations.KeyValuePrefix + package.PackageName);
+                    .GetValueOrDefault(Constants.Conventions.Migrations.KeyValuePrefix + group.Key.PackageId);
 
                 package.PackageMigrationPlans = group
                     .Select(plan => new InstalledPackageMigrationPlans

diff --git a/src/Umbraco.Web.UI.Client b/src/Umbraco.Web.UI.Client
diff --git a/templates/UmbracoProject/wwwroot/favicon.ico b/templates/UmbracoProject/wwwroot/favicon.ico