Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: use CircleMarker instead of Circle icon #2061

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yohanboniface
Copy link
Member

@yohanboniface yohanboniface commented Aug 15, 2024

This needs more work, but would allow:

  • better performance: - one svg for all features instead of one HTML per feature - as it inherits from path, only visible feature are added to DOM
  • controling the circle radius, which is something requested from time to time

To move forward, we need:

  • to have default per UI class (instead of in the SCHEMA), as for example we do not want the same default weight for a line or for the CircleMarker
  • maybe to have some static properties, so to keep the circle border color always white, as now (but can be discussed)
  • when editing a feature, to show properties according to the current selected UI class, so user can define the radius when "Circle" is selected, but also other path related properties (fillColor, opacity…)

This needs more work, but would allow:
- better performance:
    - one svg for all features instead of one HTML per feature
    - as it inherits from path, only visible feature are added to DOM
- controling the circle radius, which is something requested from time
  to time

To move forward, we need:

- [ ] to have default per UI class (instead of in the SCHEMA), as
 for example we do not want the same default weight for a line or
 for the CircleMarker
- [ ] maybe to have some static properties, so to keep the circle
  border color always white, as now (but can be discussed)
- [ ] when editing a feature, to show properties according to the
  current selected UI class, so user can define the radius when
  "Circle" is selected, but also other path related properties
  (fillColor, opacity…)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant