Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a signature to the payreq response #16

Merged
merged 3 commits into from
Feb 16, 2024

Conversation

shreyav
Copy link
Contributor

@shreyav shreyav commented Feb 15, 2024

No description provided.

@@ -17,7 +17,12 @@ The full structure of the LNURLP response is:
"utxos": string[],
// A url which the sending VASP should call on transaction completion to notify the receiving VASP of
// the utxos used to complete the transaction. See [UMAD-07](/umad-07-post-tx-hooks.md).
"utxoCallback": string
"utxoCallback": string,
// The receiving VASP's signature over sha256_hash(<sender UMA> (eg. [email protected]) + <receiver UMA> (eg. [email protected]) +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we easily have access to both the sending and receiving UMA on the receiving VASP at this point? I think we should, but it might be good to check out one of the demo VASPs just to make sure this will be straightforward to do in practice without needing to store a bunch of stuff.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have easy access to the sending UMA and the receiving VASP should(??) know the receiver's UMA, but maybe we should include the sender UMA only for simplicity?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm now that I think about it, I think VASPS will need to have the receiver uma anyway at this point one way or another for their own internal ledgering. Sorry for the back-and-forth on this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually let's remove it. jk, lgtm.

@@ -17,7 +17,12 @@ The full structure of the LNURLP response is:
"utxos": string[],
// A url which the sending VASP should call on transaction completion to notify the receiving VASP of
// the utxos used to complete the transaction. See [UMAD-07](/umad-07-post-tx-hooks.md).
"utxoCallback": string
"utxoCallback": string,
// The receiving VASP's signature over sha256_hash(<sender UMA> (eg. [email protected]) + <receiver UMA> (eg. [email protected]) +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually let's remove it. jk, lgtm.

@shreyav shreyav merged commit e9d54c9 into release/v1.0 Feb 16, 2024
1 check passed
@shreyav shreyav deleted the feat/payreqresponse-signature branch February 16, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants