Fix errors with reload lua scripts #124
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactoring started when I had an issue testing if the reloading was safe for concurrent use, using SCRIPT FLUSH command on a Redis instance.
Reusing the benchmark provided and adding the flag
-race
with multiple goroutines, I've detected that there was several issues.The first one was with the second execution of
EvalSha
, theargs...
were missing, producing an error on the Lua increment script because there was no argument given.limiter/drivers/store/redis/store.go
Line 179 in aa44c77
The second one was with an data race detected because multiple goroutines could read (without protection) when one could write to modify
store.luaIncrSHA
. Better safe than sorry, I've added a method to ensure that there is no data race, even if the impact is pretty minimal.limiter/drivers/store/redis/store.go
Line 114 in aa44c77
limiter/drivers/store/redis/store.go
Line 123 in aa44c77
One thing led to another and I was down the rabbit hole so, I've done some refactoring.
@git-hulk Feel free to take a look.