-
-
Notifications
You must be signed in to change notification settings - Fork 16.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix the path error in export.py #5778
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Hello @miknyko, thank you for submitting a 🚀 PR! To allow your work to be integrated as seamlessly as possible, we advise you to:
- ✅ Verify your PR is up-to-date with upstream/master. If your PR is behind upstream/master an automatic GitHub actions rebase may be attempted by including the /rebase command in a comment body, or by running the following code, replacing 'feature' with the name of your local branch:
git remote add upstream https://github.com/ultralytics/yolov5.git
git fetch upstream
git checkout feature # <----- replace 'feature' with local branch name
git merge upstream/master
git push -u origin -f
- ✅ Verify all Continuous Integration (CI) checks are passing.
- ✅ Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." -Bruce Lee
@miknyko export works correctly, it is verified in our CI checks every 24 hours and on every commit: If you find a reproducible bug please submit a bug report, thank you! |
and by the way im using python3.8 |
@miknyko ah ok got it. Can you submit a PR to use a |
No problem |
* fix the path error in export.py * Update export.py Co-authored-by: Glenn Jocher <[email protected]>
Hi, guys
I found a small bug in export.py.
the variable f is a pathlib.Path , which cannot be directly passed in scriptmodel.save
it has to be callled .as_posix() to get a string representation of the path
at least in windows
or there will be an error saying
TorchScript: export failure: save(): incompatible function arguments. The following argument types are supported: 1. (self: torch._C.ScriptModule, filename: str, _extra_files: Dict[str, str] = {}) -> None
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
This PR appears to be a placeholder or an error since there are no code changes.
📊 Key Changes
🎯 Purpose & Impact