-
-
Notifications
You must be signed in to change notification settings - Fork 16.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shadow eval
fix
#5225
Shadow eval
fix
#5225
Conversation
Fixes out of bounds labels that seem to affect ~10% of images in dataset.
…named it to evaluation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Hello @NaelsonDouglas, thank you for submitting a 🚀 PR! To allow your work to be integrated as seamlessly as possible, we advise you to:
- ✅ Verify your PR is up-to-date with origin/master. If your PR is behind origin/master an automatic GitHub actions rebase may be attempted by including the /rebase command in a comment body, or by running the following code, replacing 'feature' with the name of your local branch:
git remote add upstream https://github.com/ultralytics/yolov5.git
git fetch upstream
git checkout feature # <----- replace 'feature' with local branch name
git merge upstream/master
git push -u origin -f
- ✅ Verify all Continuous Integration (CI) checks are passing.
- ✅ Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." -Bruce Lee
/rebase experiment after #5255 adding Organization secret ACTIONS_TOKEN |
eval
fix
@NaelsonDouglas I need you to merge master into your fork before I can merge this PR. Please run the following commands: git remote add upstream https://github.com/ultralytics/yolov5.git
git fetch upstream
git merge upstream/master
git push -u origin -f |
There were some errors, looks like I didnt manage to make it. :( |
@NaelsonDouglas I will close this PR, please submit a new one from the latest master then, thank you! |
The problem
There was a built-in name shadowing pitfall on eval.py where the name eval, which is a Python built-in method, was being used as a variable.;
If for any reason the method gets called within that context, it would cause a hard to detect bug because eval(arg) would not be a method being called, but a variable being called as a method.
Solution
Changed the variable name to evaluation
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Enhancements and bug fixes for YOLOv5 workflows.
📊 Key Changes
.pre-commit-config.yaml
andsetup.cfg
to aid in code quality.CONTRIBUTING.md
.train.py
.🎯 Purpose & Impact