Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shadow eval fix #5225

Closed
wants to merge 3 commits into from
Closed

Conversation

NaelsonDouglas
Copy link

@NaelsonDouglas NaelsonDouglas commented Oct 17, 2021

The problem
There was a built-in name shadowing pitfall on eval.py where the name eval, which is a Python built-in method, was being used as a variable.;

If for any reason the method gets called within that context, it would cause a hard to detect bug because eval(arg) would not be a method being called, but a variable being called as a method.

Solution
Changed the variable name to evaluation

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Enhancements and bug fixes for YOLOv5 workflows.

📊 Key Changes

  • 📝 Improved the clarity of the feature request template.
  • 🔄 Added automated weekly checks for GitHub Actions with Dependabot.
  • 🔧 Updated various workflow actions to newer versions.
  • 💅 Introduced a new workflow for code formatting checks.
  • 🛠️ Various small fixes in GitHub Actions workflows, including a new workflow file for automatic code formatting (code-format.yml).
  • 📃 New files introduced such as .pre-commit-config.yaml and setup.cfg to aid in code quality.
  • 🗂️ Changed numbering in CONTRIBUTING.md.
  • 🚀 Streamlined dataset downloading in Jupyter Notebooks and scripts.
  • 👌 Autobatching improvements for efficient GPU utilization in train.py.

🎯 Purpose & Impact

  • These updates aim to keep the project's dependencies up to date, ensuring security and reliability.
  • The new workflow for automatic code formatting will improve code quality across the project.
  • Users can expect more consistent performance and improved automation for development processes, potentially resulting in fewer bugs and better code maintainability.

glenn-jocher and others added 2 commits October 15, 2021 23:19
Fixes out of bounds labels that seem to affect ~10% of images in dataset.
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hello @NaelsonDouglas, thank you for submitting a 🚀 PR! To allow your work to be integrated as seamlessly as possible, we advise you to:

  • ✅ Verify your PR is up-to-date with origin/master. If your PR is behind origin/master an automatic GitHub actions rebase may be attempted by including the /rebase command in a comment body, or by running the following code, replacing 'feature' with the name of your local branch:
git remote add upstream https://github.com/ultralytics/yolov5.git
git fetch upstream
git checkout feature  # <----- replace 'feature' with local branch name
git merge upstream/master
git push -u origin -f
  • ✅ Verify all Continuous Integration (CI) checks are passing.
  • ✅ Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." -Bruce Lee

@glenn-jocher
Copy link
Member

/rebase experiment after #5255 adding Organization secret ACTIONS_TOKEN

@glenn-jocher glenn-jocher changed the title removed a built-in method that was being shadowed Shadow eval fix Oct 27, 2021
@glenn-jocher
Copy link
Member

@NaelsonDouglas I need you to merge master into your fork before I can merge this PR. Please run the following commands:

git remote add upstream https://github.com/ultralytics/yolov5.git
git fetch upstream
git merge upstream/master
git push -u origin -f

@NaelsonDouglas
Copy link
Author

@NaelsonDouglas I need you to merge master into your fork before I can merge this PR. Please run the following commands:

git remote add upstream https://github.com/ultralytics/yolov5.git
git fetch upstream
git merge upstream/master
git push -u origin -f

There were some errors, looks like I didnt manage to make it. :(

@glenn-jocher
Copy link
Member

@NaelsonDouglas I will close this PR, please submit a new one from the latest master then, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants