-
-
Notifications
You must be signed in to change notification settings - Fork 16.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scope onnx-simplifier
requirements check
#4730
Conversation
Export.py has been updated to check for onnx-simplifier requirement only when the --simplify argument is added. Allows for better flexibility and one less requirement if simplify is not needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Hello @Zegorax, thank you for submitting a 🚀 PR! To allow your work to be integrated as seamlessly as possible, we advise you to:
- ✅ Verify your PR is up-to-date with origin/master. If your PR is behind origin/master an automatic GitHub actions rebase may be attempted by including the /rebase command in a comment body, or by running the following code, replacing 'feature' with the name of your local branch:
git remote add upstream https://github.com/ultralytics/yolov5.git
git fetch upstream
git checkout feature # <----- replace 'feature' with local branch name
git rebase upstream/master
git push -u origin -f
- ✅ Verify all Continuous Integration (CI) checks are passing.
- ✅ Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." -Bruce Lee
onnx-simplifier
requirements check
@Zegorax PR is merged. Thank you for your contributions to YOLOv5 🚀 and Vision AI ⭐ |
@Zegorax was thinking about this, it's a bit of a mixed result. If a user does not --simplify then we've improved things for them, if they do --simplify then we've doubled the calls to check_requirements(), and it will report twice independently as well, i.e. (1 package updated, 1 package updated) rather than combined (2 packages updated). |
@glenn-jocher Yes, thanks a lot for the merge. I believe it's better like this and doesn't force to have onnx-simplifier if it is not needed. |
* Changed onnx-simplifier check behavior Export.py has been updated to check for onnx-simplifier requirement only when the --simplify argument is added. Allows for better flexibility and one less requirement if simplify is not needed. * Fix single-element tuples Co-authored-by: Glenn Jocher <[email protected]>
* Changed onnx-simplifier check behavior Export.py has been updated to check for onnx-simplifier requirement only when the --simplify argument is added. Allows for better flexibility and one less requirement if simplify is not needed. * Fix single-element tuples Co-authored-by: Glenn Jocher <[email protected]>
Export.py has been updated to check for onnx-simplifier requirement only when the --simplify argument is added.
Allows for better flexibility and one less requirement if simplify is not needed.
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Improvements to ONNX export dependencies management in YOLOv5.
📊 Key Changes
onnx-simplifier
from the immediate dependency check during ONNX export.onnx-simplifier
only when simplification is required.🎯 Purpose & Impact