Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated map_location in export.py #13217

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

SangbumChoi
Copy link
Contributor

@SangbumChoi SangbumChoi commented Jul 25, 2024

map_location is deprecated in the export

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Simplified model loading in the TorchScript export function.

πŸ“Š Key Changes

  • Changed one line of code to streamline how the model is loaded onto the device.

🎯 Purpose & Impact

  • πŸ› οΈ Purpose: Simplifies code by avoiding unnecessary parameters.
  • πŸš€ Impact: Improves code maintainability and readability without affecting performance. Users benefit from cleaner, more efficient code execution.

Signed-off-by: Sangbum Daniel Choi <[email protected]>
Copy link
Contributor

github-actions bot commented Jul 25, 2024

All Contributors have signed the CLA. βœ…
Posted by the CLA Assistant Lite bot.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘‹ Hello @SangbumChoi, thank you for submitting a YOLOv5 πŸš€ PR! To allow your work to be integrated as seamlessly as possible, we advise you to:

  • βœ… Verify your PR is up-to-date with ultralytics/yolov5 master branch. If your PR is behind you can update your code by clicking the 'Update branch' button or by running git pull and git merge master locally.
  • βœ… Verify all YOLOv5 Continuous Integration (CI) checks are passing.
  • βœ… Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." β€” Bruce Lee

@SangbumChoi
Copy link
Contributor Author

I have read the CLA Document and I sign the CLA

@UltralyticsAssistant UltralyticsAssistant added enhancement New feature or request python labels Jul 25, 2024
@glenn-jocher
Copy link
Member

@SangbumChoi thank you for your contributions!

@glenn-jocher glenn-jocher changed the title Update export.py Remove deprecated map_location in export.py Jul 25, 2024
@glenn-jocher glenn-jocher merged commit 6deb2d7 into ultralytics:master Jul 25, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants