Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update links.yml to --scheme https #12625

Merged
merged 1 commit into from
Jan 13, 2024
Merged

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Jan 13, 2024

Thank you 🙏 for your contribution to Ultralytics 🚀! Your effort in enhancing our repositories is greatly appreciated. To streamline the process and assist us in integrating your Pull Request (PR) effectively, please follow these steps:

  1. Check for Existing Contributions: Before submitting, kindly explore existing PRs to ensure your contribution is unique and complementary.

  2. Link Related Issues: If your PR addresses an open issue, please link it in your submission. This helps us better understand the context and impact of your contribution.

  3. Elaborate Your Changes: Clearly articulate the purpose of your PR. Whether it's a bug fix or a new feature, a detailed description aids in a smoother integration process.

  4. Ultralytics Contributor License Agreement (CLA): To uphold the quality and integrity of our project, we require all contributors to sign the CLA. Please confirm your agreement by commenting below:

    I have read the CLA Document and I hereby sign the CLA

For more detailed guidance and best practices on contributing, refer to our ✅ Contributing Guide. Your adherence to these guidelines ensures a faster and more effective review process.

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Improving link checking security in GitHub workflows with enforced HTTPS.

📊 Key Changes

  • Enforced the use of HTTPS by adding --scheme 'https' to the lychee command in GitHub Actions workflows.
  • This change applies to two separate instances within the links.yml file.

🎯 Purpose & Impact

  • 🛡️ Enhanced Security: Enforcing HTTPS improves the security of link checking, ensuring that all URLs are accessed over a secure connection.
  • 🔒 Preventing MiTM Attacks: It helps prevent Man-in-the-Middle (MiTM) attacks that can occur when using non-secure HTTP connections.
  • 👁️ User Confidence: Users can trust that the links checked in the Ultralytics repository maintain high-security standards, increasing overall trust in the integrity of the repository.

@glenn-jocher glenn-jocher merged commit 7d9a117 into master Jan 13, 2024
8 checks passed
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-2 branch January 13, 2024 21:42
pleb631 pushed a commit to pleb631/yolov5 that referenced this pull request Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant